[#38227] - [4.2] Empty error message in package install
- Fixed in Code Base
- 12 Jul 2022
- Medium
- Build: 4.2-dev
- # 38227
- Diff
- brianteeman:packageinstaller
User tests: Successful: Unsuccessful:
Pull Request for Issue #37575 .
Summary of Changes
Display an error message with text not just an empty error
Testing Instructions
npm run build:js
or install prebuilt package
Go to the package installer and try to drag & drop a folder
Actual result BEFORE applying this Pull Request
and js error in the console
Expected result AFTER applying this Pull Request
and no console errors
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings JavaScript Repository NPM Change |
were you using drag and drop?
Yes, was on administrator/index.php?option=com_installer&view=install and dragged the folder from my Windows 10 Desktop into the drop area of that page.
| Labels |
Added:
Language Change
NPM Resource Changed
?
|
||
After I've dropped the folder, it shows "Uploading 0%" or something like that for a while, and then:
Client (browser) is Windows, and the webserver is Linux.
What a pity because I think this PR is right now, and I wanted to test it with success, only I can't reproduce the issue.
Maybe some OS specific, I have "empty error" as in description, when doing "folder drag and drop" in Linux in Chrome
recorded on windows 11
Before
Hmm, no, same result when I use Firefox on my Linux server directly.
@pearlpriyanka Did you have your issue #37575 with Windows 11 as client OS where the browser was used?
Hmm, anyway, I believe you guys of course, no need for a video or animated gif. I just can't reproduce it here and would like to know why.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38227.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38227.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38227.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-12 12:15:46 |
| Closed_By | ⇒ | roland-d |
Thank you. As for the discussion of which mime-types to check, that can be a separate issue.
Unfortunately I cannot reproduce the issue here on a clean, current 4.2-dev without this PR. I don't get an empty error message when trying to upload a folder. I get a message "No Install Type Found". I've tried an empty folder and a folder with one empty file and also a folder with files and subfolders. In all cases the same result. What am I doing wrong?
P.S. The message I get is of type information or has no type. It has blue background.