NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
4 Jul 2022

Pull Request for Issue # .

Summary of Changes

  • remove some I/O operations on both the JS and SCSS minification (eg use the code output directly)
  • Ran npm lint:js -- --fix and committed the changes
    • Removed the IIFE from build/media_source/com_content/js/articles-status.es6.js as the file is correctly loaded either as module or when in nomodule it's using the defer attribute, thus adding the listener for DOMContentLoaded is pure overhead. At that point the DOM is already there fully parsed. This needs to be applied ON EVERY SCRIPT

Testing Instructions

On a fresh installation of Joomla (ie git clone) do the composer install and then the npm install. Copy the media folder somewhere in your hardisk. (check the time needed)
Now clone this PR and do both the composer and npm installations. Once done do a folder compare of the current media folder against the folder that you saved in the previous step. You should have the same files apart from the build/media_source/com_content/js/articles-status.es6.js which will have different content (expected).

Compare the times and do a brief check that both front end and back still work as expected

Actual result BEFORE applying this Pull Request

Screenshot 2022-07-04 at 18 36 53

Expected result AFTER applying this Pull Request

Screenshot 2022-07-04 at 18 35 50

Documentation Changes Required

NO

@HLeithner have somebody merge this so I could do the changes in the v5.0. Thanks

avatar dgrammatiko dgrammatiko - open - 4 Jul 2022
avatar dgrammatiko dgrammatiko - change - 4 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2022
Category Administration com_media NPM Change JavaScript Repository
avatar dgrammatiko dgrammatiko - change - 4 Jul 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 4 Jul 2022
avatar dgrammatiko dgrammatiko - change - 4 Jul 2022
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 4 Jul 2022

the change to image.vue is not correct. The span element is not self closing. Both parts are mandatory.

avatar dgrammatiko
dgrammatiko - comment - 4 Jul 2022

the change to image.vue is not correct. The span element is not self closing. Both parts are mandatory.

On your repo (4.2) try npm run lint:js -- --fix, you will get the same. The HTML inside the .vue files is totally fine with this change and actually it's the recommendation, (it's the v- part that makes the difference)

btw here's the eslint rule and the explanation: https://eslint.vuejs.org/rules/html-self-closing.html

avatar brianteeman
brianteeman - comment - 4 Jul 2022

Before

image

After

image

avatar dgrammatiko dgrammatiko - change - 12 Jul 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-07-12 22:05:37
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 12 Jul 2022
avatar dgrammatiko dgrammatiko - change - 29 Aug 2022
Status Closed New
Closed_Date 2022-07-12 22:05:37
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - change - 29 Aug 2022
Status New Pending
avatar dgrammatiko dgrammatiko - reopen - 29 Aug 2022
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2022
Category Administration com_media NPM Change JavaScript Repository JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 1 Sep 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-09-01 10:13:58
Closed_By dgrammatiko
Labels Added: PR-4.3-dev
Removed: ?
avatar dgrammatiko dgrammatiko - close - 1 Sep 2022

Add a Comment

Login with GitHub to post a comment