? Release Blocker NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
28 Jun 2022

Summary of Changes

This is redo #38019 and #38030

The PR allow Joomla.request to return a Promise.
And add Joomla.enqueueRequest method to allow run the requests in sequence.

It is better if it will be tested and accepted before 4.2 release.

Testing Instructions

Please follow #38019
Because it a redo of that PR, make sure tha it still works as there described.

Documentation Changes Required

Need update Joomla.request docs if we have one, and docs for Joomla.enqueueRequest

bip bip @nikosdion, so it actualy possible ?

avatar Fedik Fedik - open - 28 Jun 2022
avatar Fedik Fedik - change - 28 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jun 2022
Category JavaScript Repository NPM Change
ed24c23 28 Jun 2022 avatar Fedik jscs
avatar Fedik Fedik - change - 28 Jun 2022
Labels Added: NPM Resource Changed ?
avatar nikosdion
nikosdion - comment - 28 Jun 2022

Sorry, it was dinner time over here. Let me create a testing environment for this and I'll get back to you.

avatar Fedik
Fedik - comment - 28 Jun 2022

I will fix that things one of next days

avatar Fedik
Fedik - comment - 29 Jun 2022

Should be good now

avatar martin-zw martin-zw - test_item - 5 Jul 2022 - Tested successfully
avatar martin-zw
martin-zw - comment - 5 Jul 2022

I have tested this item successfully on 6613b2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38172.

avatar viocassel viocassel - test_item - 6 Jul 2022 - Tested successfully
avatar viocassel
viocassel - comment - 6 Jul 2022

I have tested this item successfully on 6613b2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38172.

avatar richard67 richard67 - change - 6 Jul 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 6 Jul 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38172.

avatar Fedik
Fedik - comment - 8 Jul 2022

@roland-d I have set it RB because if we do not merge it before 4.2 release then it cannot be merged untill 5.x

avatar roland-d roland-d - change - 11 Jul 2022
Labels Added: ? Release Blocker
avatar roland-d roland-d - change - 11 Jul 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-07-11 11:43:11
Closed_By roland-d
avatar roland-d roland-d - close - 11 Jul 2022
avatar roland-d roland-d - merge - 11 Jul 2022
avatar roland-d
roland-d - comment - 11 Jul 2022

Thanks everybody

avatar jobrusche
jobrusche - comment - 19 Jan 2023

This is still an issue in Joomla! 4.2.6

avatar brianteeman
brianteeman - comment - 19 Jan 2023

Please open a new issue with more details - few people see comments on merged pull requests. You can include a reference to this Pull Request if it is relevant in your new issue

Add a Comment

Login with GitHub to post a comment