Feeling Lucky
NPM Resource Changed
?
[#38171] - [4.2] Cleanup some inline phpcs:ignore
- Fixed in Code Base
- 30 Jun 2022
- Medium
- Build: 4.2-dev
- # 38171
- Diff
- Digital-Peak:j4/cs/cleanup
User tests: Successful: Unsuccessful:
Removes some inline CS ignores which can be removed since the transition to PSR 12 is done.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_users JavaScript Repository NPM Change Front End Layout Libraries Plugins |
| Labels |
Added:
NPM Resource Changed
?
|
||
nikosdion
- comment
- 28 Jun 2022
The statements were just there to get the PR checks to pass as I was violating Joomla's code style which did not take several things into account, e.g. the fact that some legacy properties which we still have to use were snake_case instead of camelCase. Since your checks pass here, including the PHPCS ones, there's no problem with me :)
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-30 06:30:30 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 30 Jun 2022
Thanks
@nikosdion you might want to have a look here as if I'm not mistaken, then I removed some of your recent cs:ignore statements.