? ? PHP 8.x Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
17 Jun 2022

Pull Request for Issue #38032 .

Fix of
Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in \libraries\src\Language\Text.php on line 97

Summary of Changes

Exit the method passSprintf() in Text if the String is empty.

Testing Instructions

See #38032.

avatar chmst chmst - open - 17 Jun 2022
avatar chmst chmst - change - 17 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2022
Category Libraries
avatar viocassel viocassel - test_item - 17 Jun 2022 - Tested successfully
avatar viocassel
viocassel - comment - 17 Jun 2022

I have tested this item successfully on 0383564


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38081.

avatar alikon
alikon - comment - 17 Jun 2022

i don't think this is a correct fix it should be not called at all if null/empty

avatar laoneo
laoneo - comment - 17 Jun 2022

As long as the argument is not typed, we need to check it.

avatar laoneo laoneo - test_item - 17 Jun 2022 - Tested successfully
avatar laoneo
laoneo - comment - 17 Jun 2022

I have tested this item successfully on 0383564


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38081.

avatar richard67 richard67 - change - 17 Jun 2022
Status Pending Ready to Commit
Labels Added: ? PHP 8.x
avatar richard67
richard67 - comment - 17 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38081.

avatar bembelimen bembelimen - close - 18 Jun 2022
avatar bembelimen bembelimen - merge - 18 Jun 2022
avatar bembelimen bembelimen - change - 18 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-18 09:55:08
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 18 Jun 2022

Thx

Add a Comment

Login with GitHub to post a comment