? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar nikosdion
nikosdion
17 Jun 2022

Pull Request for comment #37912 (comment).

Ping @Kostelano @richard67

Summary of Changes

Adds captive login prompts for these MFA methods:

  • Backup Codes
  • TOTP (Authenticator Code)
  • YubiKey

The rest of the methods already had it:

  • Email
  • Fixed
  • WebAuthn

Testing Instructions

  • Set up MFA using authentication code and YubiKey
  • Note down your Backup Codes
  • Log out and log back in

Actual result BEFORE applying this Pull Request

Choosing to validate with backup codes, TOTP or YubiKey would only display a text box without any help text to help you understand what to do.

Expected result AFTER applying this Pull Request

There is help text above the text box explaining how to obtain the code and proceed with the MFA.

Documentation Changes Required

None

Adds language strings

These three methods didn't have a captive prompt language string. I added three strings.

avatar nikosdion nikosdion - open - 17 Jun 2022
avatar nikosdion nikosdion - change - 17 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2022
Category Administration com_users Language & Strings Front End Plugins
avatar nikosdion nikosdion - change - 17 Jun 2022
Labels Added: Language Change ?
avatar richard67 richard67 - test_item - 17 Jun 2022 - Tested successfully
avatar richard67
richard67 - comment - 17 Jun 2022

I have tested this item successfully on b5c7d4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082.

avatar Kostelano Kostelano - test_item - 17 Jun 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 17 Jun 2022

I have tested this item successfully on b5c7d4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082.

avatar richard67 richard67 - change - 17 Jun 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082.

avatar Quy Quy - change - 17 Jun 2022
Labels Added: ?
avatar fancyFranci fancyFranci - change - 18 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-18 09:30:58
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 18 Jun 2022
avatar fancyFranci fancyFranci - merge - 18 Jun 2022
avatar fancyFranci
fancyFranci - comment - 18 Jun 2022

Thank you for the improvement!

Add a Comment

Login with GitHub to post a comment