? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
16 Jun 2022

Pull Request for Issue #38077 .

Summary of Changes

  • Add language string JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_CONNECT taken from the "lib_joomla.ini" language file to the installation language file. This is what has been done before with PR #37286 for other languages strings from the library which were not translated in the installation.
  • The installer's languages model should not use language string COM_INSTALLER_MSG_INSTALL_INVALID_URL from "com_installer.ini". Therefore add a new sting INSTL_ERROR_INVALID_URL to the installation language file and use that string instead of the one from the component in the model.

Testing Instructions

It's very likely that you can't reproduce the errors mentioned in the description of issue #38077 to cause the untranslated string being shown, so we might be limited to code review here.

But if you can reproduce it, then please do a real test and report back how you have tested.

Actual result BEFORE applying this Pull Request

Untranslated strings mentioned in the issue are shown in certain case of error.

Expected result AFTER applying this Pull Request

The strings are translated in this particular case of error.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 16 Jun 2022
avatar richard67 richard67 - change - 16 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2022
Category Installation Language & Strings
avatar richard67 richard67 - change - 16 Jun 2022
The description was changed
avatar richard67 richard67 - edited - 16 Jun 2022
avatar Kostelano Kostelano - test_item - 16 Jun 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 16 Jun 2022

I have tested this item successfully on fc5c8c0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38080.

avatar viocassel viocassel - test_item - 16 Jun 2022 - Tested successfully
avatar viocassel
viocassel - comment - 16 Jun 2022

I have tested this item successfully on fc5c8c0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38080.

avatar Quy Quy - change - 16 Jun 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 16 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38080.

avatar roland-d roland-d - change - 17 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-17 05:54:41
Closed_By roland-d
Labels Added: ?
avatar roland-d roland-d - close - 17 Jun 2022
avatar roland-d roland-d - merge - 17 Jun 2022
avatar roland-d
roland-d - comment - 17 Jun 2022

Thank you

Add a Comment

Login with GitHub to post a comment