? ? Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
16 Jun 2022

Summary of Changes

Adjust Namespace
Remove unsed Import
Fix doc

Testing Instructions

Run composer install

Actual result BEFORE applying this Pull Request

It shows the warning:
image
Class Joomla\Tests\Unit\Libraries\Cms\User\CacheControllerFactoryAwareTraitTest located in ./tests/Unit/Libraries/Cms/Cache/CacheControllerFactoryAwareTraitTest.php does not comply with psr-4 autoloading standard. Skipping.

Expected result AFTER applying this Pull Request

Runs through.
Drone run successfully.

avatar heelc29 heelc29 - open - 16 Jun 2022
avatar heelc29 heelc29 - change - 16 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2022
Category Unit Tests
avatar laoneo laoneo - change - 16 Jun 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-16 14:17:48
Closed_By laoneo
Labels Added: ? ?
avatar laoneo laoneo - close - 16 Jun 2022
avatar laoneo laoneo - merge - 16 Jun 2022
avatar laoneo
laoneo - comment - 16 Jun 2022

Thanks!

avatar richard67
richard67 - comment - 16 Jun 2022

Just wanted to post that ok for my by review ? .

avatar richard67
richard67 - comment - 16 Jun 2022

Success can be seen in the log file from the composer step of drone: https://ci.joomla.org/joomla/joomla-cms/55394/1/5 . The warning has gone. In the drone log of this step from before this PR, the warning is still there, see e.g. https://ci.joomla.org/joomla/joomla-cms/55389/1/5 . So you can count this as successful test.

Add a Comment

Login with GitHub to post a comment