No Code Attached Yet
avatar Kostelano
Kostelano
16 Jun 2022

Steps to reproduce the issue

Most likely the problem will not be reproduced, but just when installing the latest 4.2, I received errors with missing lines at the step of installing the localization pack.

They must be duplicated in the localization file when installing Joomla.

JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_CONNECT
COM_INSTALLER_MSG_INSTALL_INVALID_URL

Screenshot_1

avatar Kostelano Kostelano - open - 16 Jun 2022
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Jun 2022
avatar richard67
richard67 - comment - 16 Jun 2022

Should be a similar PR as #37286 before.

@Kostelano Do you think you can make a PR?

avatar brianteeman
brianteeman - comment - 16 Jun 2022

I couldnt replicate it as you expected

Installation in russian

Date: June 16, 2022

Author: Brian Teeman

Source: Tango


1. Go to Joomla Installer

2. Click on Параметры сайта…

Step 2 screenshot

3. Type "Site Name"

Step 3 screenshot

4. Click on Параметры учетной записи

Step 4 screenshot

5. Type "My Full Name"

Step 5 screenshot

6. Type "admin"

Step 6 screenshot

7. Type password

Step 7 screenshot

8. Type "admin@example.com"

Step 8 screenshot

9. Click on Параметры базы данных

Step 9 screenshot

10. Type "joomla_ru"

Step 10 screenshot

11. Type "root"

Step 11 screenshot

12. Click on Установить Joomla

Step 12 screenshot

13. Click on Завершение установки…

Step 13 screenshot

14. Click on Установить языковые пакеты

Step 14 screenshot

15. Check Russian

Step 15 screenshot

16. Click on Далее…

Step 16 screenshot

17. Click on Russian (ru-RU) ru-RU

Step 17 screenshot

18. Select "ru-RU"

Step 18 screenshot

19. Select "ru-RU"

Step 19 screenshot

20. Click on Языковые пакеты установлены. Пожалуйста, выберите язык по умолчанию для панели управления и нажмите "Установить по умолчанию".…

Step 20 screenshot

21. Click on Открыть панель управления

Step 21 screenshot


This workflow was created with Tango

avatar richard67
richard67 - comment - 16 Jun 2022

@brianteeman But maybe it could make sense to add the untranslated error messages shown in @Kostelano 's screen shot to the installation/language/en-GB/joomla.ini file regardless of that?

avatar brianteeman
brianteeman - comment - 16 Jun 2022

For the COM_ More likely the solution is to add a string INSTL_to the installation and update the php accordingly

avatar richard67
richard67 - comment - 16 Jun 2022

For the COM_ More likely the solution is to add a string INSTL_to the installation and update the php accordingly

That's right.

When checking in which PHP files outside of the "administrator/components/com_installer" folder are using language stings like "COM_INSTALLER_", I find:

libraries/src/Console/ExtensionRemoveCommand.php
plugins/installer/packageinstaller/tmpl/default.php
plugins/installer/webinstaller/tmpl/default.php
installation/src/Model/LanguagesModel.php
layouts/joomla/installer/changelog.php

But we have language string with keys like "COM_INSTALLER_" only in the "com_installer" language files of the backend, and that's how it should be.

The "installation/src/Model/LanguagesModel.php" really should not use "COM_INSTALLER_" language strings.

As far as I can see it uses only that one here: https://github.com/joomla/joomla-cms/blob/4.2-dev/installation/src/Model/LanguagesModel.php#L292

So this should be changed to an "INSTL_" sting which should then be added to the "installation/language/en-GB/joomla.ini" file.

The "JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_CONNECT" should be added to the same file at the right place.

And now the important question: Who wants to make the PR? ?

avatar richard67
richard67 - comment - 16 Jun 2022

If nobody else wants to make a PR, I can make one, but I want to avoid us doing duplicate work in parallel, so if someone is already working on it let me know. I'll wait a while.

avatar Kostelano
Kostelano - comment - 16 Jun 2022

If nobody else wants to make a PR, I can make one, but I want to avoid us doing duplicate work in parallel, so if someone is already working on it let me know. I'll wait a while.

Sorry, I'm not at home at the PC, so I can't right now.

avatar brianteeman
brianteeman - comment - 16 Jun 2022

And I am at the pub

avatar richard67 richard67 - change - 16 Jun 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-06-16 19:11:31
Closed_By richard67
avatar richard67 richard67 - close - 16 Jun 2022
avatar richard67
richard67 - comment - 16 Jun 2022

Closing as having a pull request. Please test #38080 , either by code review, or if you can reproduce the error which causes the mentioned strings to be shown, do a real test. Thanks in advance.

Add a Comment

Login with GitHub to post a comment