Most likely the problem will not be reproduced, but just when installing the latest 4.2, I received errors with missing lines at the step of installing the localization pack.
They must be duplicated in the localization file when installing Joomla.
JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_CONNECT
COM_INSTALLER_MSG_INSTALL_INVALID_URL
Labels |
Added:
No Code Attached Yet
|
I couldnt replicate it as you expected
Date: June 16, 2022
Author: Brian Teeman
Source: Tango
@brianteeman But maybe it could make sense to add the untranslated error messages shown in @Kostelano 's screen shot to the installation/language/en-GB/joomla.ini
file regardless of that?
For the COM_ More likely the solution is to add a string INSTL_to the installation and update the php accordingly
For the COM_ More likely the solution is to add a string INSTL_to the installation and update the php accordingly
That's right.
When checking in which PHP files outside of the "administrator/components/com_installer" folder are using language stings like "COM_INSTALLER_", I find:
libraries/src/Console/ExtensionRemoveCommand.php
plugins/installer/packageinstaller/tmpl/default.php
plugins/installer/webinstaller/tmpl/default.php
installation/src/Model/LanguagesModel.php
layouts/joomla/installer/changelog.php
But we have language string with keys like "COM_INSTALLER_" only in the "com_installer" language files of the backend, and that's how it should be.
The "installation/src/Model/LanguagesModel.php" really should not use "COM_INSTALLER_" language strings.
As far as I can see it uses only that one here: https://github.com/joomla/joomla-cms/blob/4.2-dev/installation/src/Model/LanguagesModel.php#L292
So this should be changed to an "INSTL_" sting which should then be added to the "installation/language/en-GB/joomla.ini" file.
The "JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_CONNECT" should be added to the same file at the right place.
And now the important question: Who wants to make the PR?
If nobody else wants to make a PR, I can make one, but I want to avoid us doing duplicate work in parallel, so if someone is already working on it let me know. I'll wait a while.
If nobody else wants to make a PR, I can make one, but I want to avoid us doing duplicate work in parallel, so if someone is already working on it let me know. I'll wait a while.
Sorry, I'm not at home at the PC, so I can't right now.
And I am at the pub
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-16 19:11:31 |
Closed_By | ⇒ | richard67 |
Should be a similar PR as #37286 before.
@Kostelano Do you think you can make a PR?