? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
1 May 2022

Pull Request for Issue #37645 replaces PR #37708

Summary of Changes

The Privacy Consent decision is placed inline. It saves space and has a better usability

Testing Instructions

Turn on the Privacy consent plugin
Turn on the Terms of Service plugin
Apply Patch an see if the radio buttons on the registration page and on the profile edit page display correct

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Documentation Changes Required

No

avatar coolcat-creations coolcat-creations - open - 1 May 2022
avatar coolcat-creations coolcat-creations - change - 1 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2022
Category Repository NPM Change
avatar richard67 richard67 - change - 1 May 2022
Title
Cassiopeia Privacy Consent - Display Options Inline #37708
Cassiopeia Privacy Consent - Display Options Inline
avatar richard67 richard67 - edited - 1 May 2022
avatar ChristineWk
ChristineWk - comment - 1 May 2022

I have tested this item successfully on 38f5fc8

with Prebuilt Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37709.

avatar ChristineWk ChristineWk - test_item - 1 May 2022 - Tested successfully
avatar coolcat-creations coolcat-creations - change - 2 May 2022
Labels Added: NPM Resource Changed ?
avatar joomleb
joomleb - comment - 11 May 2022

Hi guys,
thinking about seeing this little fixed improvement in the 4.1.3 release, Please, What is the plan here?

avatar coolcat-creations
coolcat-creations - comment - 11 May 2022

We need at least two Tests to possibly merge it into core

avatar ChristineWk
ChristineWk - comment - 11 May 2022

I have tested this item successfully on 27e642c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37709.

4.1.3-rc2-dev+pr37709 Package

avatar ChristineWk ChristineWk - test_item - 11 May 2022 - Tested successfully
avatar coolcat-creations
coolcat-creations - comment - 12 May 2022

Two tests from independent people ;-) ? but thank you @ChristineWk - @joomleb do you want to test as well?

avatar joomleb
joomleb - comment - 12 May 2022

@coolcat-creations
thanks for your reply.
I tried it on a Joomla 4.1.3 installation here by override the .../media/templates/site/cassiopeia/scss/blocks/_form.scss changed file (cleared Joomla cache, tested with Chrome and Firefox anonymous browsing), but as far as I see it is not running.
Please What am I missing?

avatar coolcat-creations
coolcat-creations - comment - 12 May 2022

Did you install a prebuilt package applied here in the PR?

avatar joomleb
joomleb - comment - 13 May 2022

@coolcat-creations

"...Did you install a prebuilt package..." = No, as I wrote I just tried it on a Joomla 4.1.3 installation here by override the .../media/templates/site/cassiopeia/scss/blocks/_form.scss changed file

"...applied here in the PR?" = Please, Where and How ?

  • I think I got the link here above
  • I downloaded the "joomla-cms-fix-37708b" zip package
  • I installed it in the Joomla 4.1.3 installation
  • Nothing is changed (the link I gave you)
avatar Quy
Quy - comment - 13 May 2022

Please scroll to the bottom of this page. Look for the link to Show all checks to see the link to download the package.

37709

avatar Quy Quy - alter_testresult - 13 May 2022 - joomleb: Tested successfully
avatar Quy Quy - edited - 13 May 2022
avatar Quy Quy - change - 13 May 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37709.

avatar laoneo laoneo - change - 13 May 2022
Labels Added: ?
avatar laoneo laoneo - change - 15 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-15 17:17:00
Closed_By laoneo
avatar laoneo laoneo - close - 15 May 2022
avatar laoneo laoneo - merge - 15 May 2022
avatar laoneo
laoneo - comment - 15 May 2022

Thanks!

Add a Comment

Login with GitHub to post a comment