[#37708] - Cassiopeia Privacy Consent - Display Options Inline
- Closed
- 1 May 2022
- Medium
- Build: 4.1-dev
- # 37708
- Diff
- coolcat-creations:fix#37645
User tests: Successful: Unsuccessful:
Pull Request for Issue #37645 .
Summary of Changes
The Privacy Consent decision is placed inline. It saves space and has a better usability
Testing Instructions
Turn on the Privacy consent plugin
Turn on the Terms of Service plugin
Apply Patch an see if the radio buttons on the registration page and on the profile edit page display correct
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@coolcat-creations I think the reason for problem with the unwanted changes in the _toolbar.scss files is that you have created the branch for this PR based on the branch for your other PR #37707 instead of your 4.1-dev branch, possibly because the branch of the other PR was actual branch, and when creating a new branch, git defaults to the actual branch as base branch if you don't specify something else.
Later you tried to fix that by deleting the file, but that's wrong. You should have replaced it by the one from a clean 4.10-dev branch.
The easiest way to fix this now is to close this PR and do it again with another, new branch, this time based on your 4.1-dev branch (or better, the 4.1-dev branch of the upstream repo = this repo here).
For the mean time I leave the issue open because this PR here is wrong like it is now and so will not fix the issue without breaking something else.
oh no sorry :-D I fix this
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-01 11:34:57 |
| Closed_By | ⇒ | coolcat-creations |
Thanks.
@coolcat-creations Is it by purpose that your PR now deletes the _toolbar.scss file instead of just reverting the unwanted changes in it?