Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#37707] - Fix button focus boder cut off

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
1 May 2022

Pull Request for Issue #37706.

Summary of Changes

I added a 0.25 rem distance to the left of the toolbar so that the focus border is not cut off.

Testing Instructions

Apply patch and in Cassiopeia Frontend in the Media Modal window the Upload Button should have a full focus border

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Documentation Changes Required

No

avatar coolcat-creations coolcat-creations - open - 1 May 2022
avatar coolcat-creations coolcat-creations - change - 1 May 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2022
Category ⇒ Repository NPM Change
avatar brianteeman
brianteeman - comment - 1 May 2022

Sorry but this is not correct as it wont work on an rtl site and it's so generic that it will have an impact everywhere.

Pretty sure that the correct fix is to change the padding in the subhead class below

joomla-cms/build/media_source/templates/site/cassiopeia/scss/blocks/_toolbar.scss

Lines 1 to 12 in d43e5a5

.subhead {
position: sticky;
top: 0;
right: 0;
left: 0;
z-index: $zindex-toolbar;
width: auto;
min-height: 43px;
padding: 10px 0;
color: #495057; //#0c192e;
background: $white;
box-shadow: -3px -2px 22px #ddd;

changing from padding: 10px 0 to simply padding: 10px should do it

avatar coolcat-creations coolcat-creations - change - 1 May 2022
Labels Added: NPM Resource Changed ?
avatar coolcat-creations
coolcat-creations - comment - 1 May 2022

Ok, thanks for the suggestion I changed it

avatar crystalenka
crystalenka - comment - 2 May 2022

I have tested this item ✅ successfully on edbe8d2

Fixes the focus border for me. :) thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37707.

avatar crystalenka crystalenka - test_item - 2 May 2022 - Tested successfully
avatar Quy
Quy - comment - 2 May 2022

I have tested this item ✅ successfully on edbe8d2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37707.

avatar Quy Quy - test_item - 2 May 2022 - Tested successfully
avatar Quy Quy - change - 2 May 2022
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 2 May 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37707.

avatar pritam825
pritam825 - comment - 11 May 2022

I have tested this item ✅ successfully on edbe8d2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37707.

avatar pritam825 pritam825 - test_item - 11 May 2022 - Tested successfully
avatar laoneo laoneo - change - 13 May 2022
Labels Added: ?
avatar laoneo laoneo - change - 13 May 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-05-13 12:03:18
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 13 May 2022
avatar laoneo laoneo - merge - 13 May 2022
avatar laoneo
laoneo - comment - 13 May 2022

Thanks!

Add a Comment

Login with GitHub to post a comment