[#37611] - [4.2] Inject the database into the finder classes
- Fixed in Code Base
- 18 Jun 2022
- Medium
- Build: 4.2-dev
- # 37611
- Diff
- Digital-Peak:j4/finder/db-cleanup
User tests: Successful: Unsuccessful:
Summary of Changes
Ongoing effort to inject the database into components and get rid of the deprecated Factory::getDbo(); calls. This pr injects the database in the finder component instead of using the factory to get it from.
Testing Instructions
- Make sure the smart search content plugin is enabled
- Edit an article and add a description text with the word hello
- Save the article
- Go to the url /administrator/index.php?option=com_finder&view=index and hit the Index button
- Create a search module for the front
- Search for "hello"
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Front End Modules |
Sorry, not able to test it.
In Joomla 4.2.0-alpha2-dev with PHP 8.0 and 8.1: Error before apply the path, when trying to create Smart Search module: An error has occurred. 0 Attempt to assign property "params" on null.
In Joomla 4.1.3-dev with PHP 8.1: if I apply the path I obtain an error in frontend: ClassNotFoundError. Details:
Symfony\Component\ErrorHandler\Error\ClassNotFoundError:
Attempted to load trait "DatabaseAwareTrait" from namespace "Joomla\Database".
Did you forget a "use" statement for another namespace?
at /shared/httpd/Joomla_4.1.3-dev/htdocs/administrator/components/com_finder/src/Service/HTML/Finder.php:26
Thank you and best regards
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37611.
@pabloarias Make sure you are on the 4.2 branch!
| Labels |
Added:
PBF
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-18 13:55:26 |
| Closed_By | ⇒ | roland-d |
Thanks everybody.
I have tested this item✅ successfully on 3911c15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37611.