Feeling Lucky
?
PBF
?
[#37610] - [4.2] Does a cleanup of the contact icon HTML service
- Fixed in Code Base
- 23 Apr 2022
- Medium
- Build: 4.2-dev
- # 37610
- Diff
- Digital-Peak:j4/contact/edit-front-cleanup
User tests: Successful: Unsuccessful:
Summary of Changes
Since #24311 front en editing of contacts is possible. This pr does a cleanup in the icon class which uses static functions and injects a user factory. Additionally it removes an obsolete null db check as dates are null in Joomla anyway.
Testing Instructions
- Create a new contact
- Create a contact list menu item
- Log in on the front with an admin user
- Open the contact list
- Click on edit contact
- Close the window without hitting the cancel button
- Log in again with a different admin user
- Open the contact list menu item
Actual result BEFORE applying this Pull Request
All loads correctly.
Expected result AFTER applying this Pull Request
All loads correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact |
SumCompanyInc
- comment
- 22 Apr 2022
I have tested this item
worked for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37610.
| Status | Pending | ⇒ | Ready to Commit |
RickR2H
- comment
- 22 Apr 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37610.
zero-24
- comment
- 23 Apr 2022
Merging thanks.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-23 19:48:32 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
PBF
?
|
||
I have tested this item✅ successfully on 448cf56
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37610.