Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Apr 2022

This PR adds a check to the action logs component to determine if the plugin is enabled and if not theen it providees a modal link to enable thee modal. Exactly the same as in com_redirects

Testing Instructions

Disable the plugin "Action Logs - Joomla"

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

image

Documentation Changes Required

none

avatar brianteeman brianteeman - open - 17 Apr 2022
avatar brianteeman brianteeman - change - 17 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2022
Category Administration Language & Strings
avatar brianteeman brianteeman - change - 17 Apr 2022
Labels Added: Language Change ?
72abefb 17 Apr 2022 avatar brianteeman cs
avatar toivo
toivo - comment - 18 Apr 2022

I have tested this item ? unsuccessfully on 72abefb

Tested in Joomla 4.1.3-dev of 17 April in Wampserver using PHP 8.0.15.
The error notice was displayed but when clicking the link 'Action Log - Joomla Plugin', nothing happened. The page has the following error that is not displayed if the patch is reverted:

An error has occurred.
0 There is no "table.columns" asset of a "script" type in the registry.
Call stack

Function Location

1 () JROOT\libraries\src\WebAsset\WebAssetRegistry.php:132
2 Joomla\CMS\WebAsset\WebAssetRegistry->get() JROOT\libraries\src\WebAsset\WebAssetManager.php:277
3 Joomla\CMS\WebAsset\WebAssetManager->useAsset() JROOT\libraries\src\WebAsset\WebAssetManager.php:201
4 Joomla\CMS\WebAsset\WebAssetManager->__call() JROOT\administrator\components\com_actionlogs\tmpl\actionlogs\default.php:27
5 include() JROOT\libraries\src\MVC\View\HtmlView.php:436
6 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT\libraries\src\MVC\View\HtmlView.php:220
7 Joomla\CMS\MVC\View\HtmlView->display() JROOT\administrator\components\com_actionlogs\src\View\Actionlogs\HtmlView.php:137
8 Joomla\Component\Actionlogs\Administrator\View\Actionlogs\HtmlView->display() JROOT\libraries\src\MVC\Controller\BaseController.php:697
9 Joomla\CMS\MVC\Controller\BaseController->display() JROOT\administrator\components\com_actionlogs\src\Controller\DisplayController.php:69
10 Joomla\Component\Actionlogs\Administrator\Controller\DisplayController->display() JROOT\libraries\src\MVC\Controller\BaseController.php:735
11 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:146
12 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT\libraries\src\Component\ComponentHelper.php:389
13 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT\libraries\src\Application\AdministratorApplication.php:143
14 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT\libraries\src\Application\AdministratorApplication.php:186
15 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT\libraries\src\Application\CMSApplication.php:278
16 Joomla\CMS\Application\CMSApplication->execute() JROOT\administrator\includes\app.php:63
17 require_once() JROOT\administrator\index.php:32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37571.
avatar toivo toivo - test_item - 18 Apr 2022 - Tested unsuccessfully
avatar toivo
toivo - comment - 18 Apr 2022

Sorry, wrong dev version!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37571.

avatar richard67 richard67 - alter_testresult - 18 Apr 2022 - toivo: Not tested
avatar richard67
richard67 - comment - 18 Apr 2022

@toivo I've altered your test result to "Not tested" in the issue tracker due to your last comment. When you want to correct a previous test result you can do that also yourself just by using again the "Test this" button in the issue tracker and then selecting the new test result, in this case "I've not tested this item" (or so).

avatar toivo
toivo - comment - 18 Apr 2022

@richard67 thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37571.

avatar toivo
toivo - comment - 20 Apr 2022

I have tested this item successfully on 72abefb

Tested successfully in Joomla 4.2.0-alpha2-dev of 20 April in Wampserver using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37571.

avatar toivo toivo - test_item - 20 Apr 2022 - Tested successfully
avatar brianteeman brianteeman - change - 20 Apr 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-04-20 08:35:48
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 20 Apr 2022

Really frustrating to copy paste code from one component to another and be told its wrong.

As you know core is wrong I now expect that you will fix it.

avatar brianteeman brianteeman - close - 20 Apr 2022
avatar laoneo
laoneo - comment - 20 Apr 2022

I'm on it #37097, but stuff needs to be tested.

Add a Comment

Login with GitHub to post a comment