[#37570] - Show loading view in installer component properly
- Fixed in Code Base
- 19 Apr 2022
- Medium
- Build: 4.1-dev
- # 37570
- Diff
- MagnusSinger:i37516-4.1
User tests: Successful: Unsuccessful:
Pull Request for Issue #37516
Note: this PR is the rebase to 4.1-dev for this PR: #37538 (had to create a new one because I messed something up on the other one)
Summary of Changes
When removing the "hidden" class from the loading view in the installer component in the inspector, this view is now properly positioned
Testing Instructions
Go to the extension installer, open the inspector and search for the div with the ID "loading", then remove the "hidden" class from it
Actual result BEFORE applying this Pull Request
The loading view was positioned below the main content and was invisible
Expected result AFTER applying this Pull Request
The loading view is now visible and properly positioned
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@brianteeman Could you test this PR, too? It's the same as #37538 , but this time for the 4.1-dev branch. Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-19 11:54:53 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks!!
I have tested this item✅ successfully on 01bed1d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37570.