[#37572] - Update FieldsListPlugin.php
- Closed
- 18 Apr 2022
- Medium
- Build: 4.1-dev
- # 37572
- Diff
- varaprasad16:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #37429
Summary of Changes
Written the for loop code for copying data from params to $data after cloning the params data. so that $data will copy the data this->params data
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Labels |
Added:
?
|
||
@varaprasad16 Now there are other code style errors: https://ci.joomla.org/joomla/joomla-cms/53403/1/6 . Maybe you should adjust your editor so it shows you spaces and tabs.
@varaprasad16 Your last commit makes it even worse by adding another tab to an empty line.
Currently it's not clear yet if the issue solved by this PR is really an issue or not, see my comment in the issue: #37429 (comment) .
@varaprasad16 Thank you for your first pull request (PR) for the Joomla CMS. Unfortunately it has turned out that the issue which your PR would solve is not an issue but expected behaviour. See the comments there. So I'll close this PR now. I hope you are not disappointed. This can happen sometimes, also to experienced contributors. Don't give up, the next one will be more lucky.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-18 15:52:52 |
| Closed_By | ⇒ | richard67 |
@varaprasad16 Your PR has code style errors. You can see that when checking the details link of the drone CI check at the bottom of the PR and then selecting the failed test on the page: https://ci.joomla.org/joomla/joomla-cms/53398/1/6 . Could you fix that? Thanks in advance.