[#37396] - [4.4] Fix media downloads with spaces
- Pending
- Medium
- Build: 4.1-dev
- # 37396
- Diff
- Vanshitasingh:4.1-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #37369.
Summary Of Changes
Fixed Media Downloads with Spaces
Testing Instructions
Replaced '%20' with space gaps using replace function.
Actual result BEFORE applying this Pull Request
The file with spaces in it loses everything between the first and second space.
Expected result AFTER applying this Pull Request
spaces are kept intact.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-28 19:37:58 |
| Closed_By | ⇒ | Vanshitasingh |
Why did you close this?
@Vanshitasingh you can add changes to your PR - make new commits, no need to make a new one .
Got it!
This is still closed?
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-03-28 19:37:58 | ⇒ | |
| Closed_By | Vanshitasingh | ⇒ |
| Status | New | ⇒ | Pending |
@Vanshitasingh please update/edit the PR title to something more descriptive like "Fix Media Downloads with Spaces" (example). You can make this change without closing the PR.
| Title |
|
||||||
| Labels |
Added:
PBF
|
||
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
This pull request has been automatically rebased to 4.3-dev.
This pull request has been automatically rebased to 4.4-dev.
| Labels |
Added:
bug
Small
PR-4.4-dev
Removed: ? |
||
I have tested this item ? unsuccessfully on 091082a
Displays Download m due to name[1] which is the second character in images/.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37396.
Can you please fix this so that we can test this during PBF on saturday?
I have tested this item ✅ successfully on 091082a
I have tested this item ✅ successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37396.
| Title |
|
||||||
Please edit this pull request so that the title is descriptive. It is used as the commit message and changelog
Then please update the first post so that it answers the questions you were asked when opening the pull request
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request