? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar MagnusSinger
MagnusSinger
28 Mar 2022

Pull Request for Issue #36545

Summary of Changes

Make the left sidebar and the top bar of the media manager sticky

Testing Instructions

Install and try to scroll down on the media manager, the control elements will stick to the top

Actual result BEFORE applying this Pull Request

The control elements will disappear when a user scrolls down

Expected result AFTER applying this Pull Request

The control elements will stick on top when a user scrolls down so they are accessible everytime

Documentation Changes Required

None

avatar MagnusSinger MagnusSinger - open - 28 Mar 2022
avatar MagnusSinger MagnusSinger - change - 28 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2022
Category Repository NPM Change
avatar brianteeman
brianteeman - comment - 28 Mar 2022

I have tested this item successfully on 39c2a15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37397.

avatar brianteeman brianteeman - test_item - 28 Mar 2022 - Tested successfully
avatar richard67
richard67 - comment - 29 Mar 2022

@MagnusSinger Please check the scss code style error reported by drone: https://ci.joomla.org/joomla/joomla-cms/52847/1/24

avatar MagnusSinger MagnusSinger - change - 29 Mar 2022
Labels Added: NPM Resource Changed ?
avatar MagnusSinger
MagnusSinger - comment - 29 Mar 2022

@richard67 thanks for the hint, I fixed it

avatar richard67 richard67 - alter_testresult - 29 Mar 2022 - brianteeman: Tested successfully
avatar richard67
richard67 - comment - 29 Mar 2022

Thanks. I've restored the previous human test result so it's properly counted since the commits after that were only code style (order of CSS properties) and a clean branch update.

avatar MagnusSinger
MagnusSinger - comment - 29 Mar 2022

Thank you

avatar Quy
Quy - comment - 31 Mar 2022

I have tested this item successfully on 4c98174


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37397.

avatar Quy Quy - test_item - 31 Mar 2022 - Tested successfully
avatar Quy Quy - alter_testresult - 31 Mar 2022 - brianteeman: Tested successfully
avatar Quy Quy - change - 31 Mar 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37397.

avatar laoneo laoneo - change - 2 Apr 2022
Labels Added: ?
avatar Quy Quy - change - 2 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-02 21:33:07
Closed_By Quy
avatar Quy Quy - close - 2 Apr 2022
avatar Quy Quy - merge - 2 Apr 2022
avatar Quy
Quy - comment - 2 Apr 2022

Thank you!

Add a Comment

Login with GitHub to post a comment