Joomla! Issue Tracker | Joomla! CMS #37342 - [4.1] Fix Deprecated warning on plugin page

? ? PHP 8.x

Fixed in Code Base
24 Mar 2022
Medium
Build: 4.1-dev
# 37342
Diff
joomdonation:patch-5

Pending

User tests: Successful: Unsuccessful:

joomdonation
21 Mar 2022

Pull Request for Issue # .

Summary of Changes

Alternative solution to PR #37324 . I think we should not pass a null or empty value to $lang->hasKey method.

Testing Instructions

Use Joomla 4 on PHP 8.1
Go to System -> Plugins, click on a plugin.

Actual result BEFORE applying this Pull Request

See message

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in /libraries/src/Language/Language.php on line 1181

Expected result AFTER applying this Pull Request

No deprecated message anymore.

05109d0 21 Mar 2022

Fix Deprecated warning on plugin page

joomdonation - open - 21 Mar 2022

joomdonation - change - 21 Mar 2022

Status

New

⇒

Pending

joomla-cms-bot - change - 21 Mar 2022

Category

⇒

Administration com_plugins

laoneo - comment - 21 Mar 2022

This is a duplicate of #37324 as it will be fixed there as well.

laoneo - comment - 21 Mar 2022

@joomdonation can you please close this one and test #37324? Thanks.

joomdonation - comment - 21 Mar 2022

@laoneo As mentioned, it's alternative to your PR and I think it is better fix. Someone mentioned that we should not pass a null (or empty string) to $lang->hasKey method, I agree and that's the reason I made this PR. I will leave the PR here to get feedback from others to see what's the preferred way to solve the issue.