No Code Attached Yet
avatar wojsmol
wojsmol
21 Mar 2022

What needs to be fixed

We need to fix the language constants in the plg_media_action language files and in the php/js files respectively. After PLG_MEDIA part, dash is used everywhere instead of hyphen (PLG_MEDIA-)

Why this should be fixed

How would you fix it

Replace PLG_MEDIA- with PLG_MEDIA_ in all places

Side Effects expected

N/A

avatar wojsmol wojsmol - open - 21 Mar 2022
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Mar 2022
avatar brianteeman
brianteeman - comment - 21 Mar 2022

Is this just for consistency or is there a bug?

avatar wojsmol
wojsmol - comment - 21 Mar 2022

This not causing any error. It's just a matter of maintaining convention.

avatar Srijan-Chak012
Srijan-Chak012 - comment - 22 Mar 2022

Hey, I'd like to start with this, can you guide me on how to get started?

avatar laoneo
laoneo - comment - 22 Mar 2022

This was done on purpose as the media action plugins have as group name media-action same as with buttons https://github.com/joomla/joomla-cms/blob/4.1-dev/administrator/language/en-GB/plg_editors-xtd_article.ini#L8

avatar richard67
richard67 - comment - 22 Mar 2022

@laoneo So the issue should be closed as expected behaviour?

avatar laoneo
laoneo - comment - 22 Mar 2022

For me yes, not sure how others feel about. All I wanted to say is that it was done on purpose at the time we made the new media manager.

avatar Hackwar
Hackwar - comment - 27 Mar 2022

As @laoneo says, this is correct the way it is with the plugin groups name. Thus this should be closed.

avatar richard67 richard67 - change - 27 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-27 20:46:18
Closed_By richard67
avatar richard67 richard67 - close - 27 Mar 2022
avatar richard67
richard67 - comment - 27 Mar 2022

Closing as expected behavior. See previous comments for explanation.

avatar wojsmol
wojsmol - comment - 27 Mar 2022

As a additional note specification of language files should be created.

Add a Comment

Login with GitHub to post a comment