? ? PHP 8.x Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
21 Mar 2022

Pull Request for Issue # .

Summary of Changes

This PR fixes Deprecated warning on HTMLHelper::_('select.integerlist') method

Testing Instructions

  1. Use Joomla 4 website on PHP 8.1
  2. Go to Global Configuration, set Error Reporting to Maximum
  3. Edit the file templates/cassiopeia/index.php, add this line of code:
echo HTMLHelper::_('select.integerlist', 1, 10, 1, 'integer_list');

Actual result BEFORE applying this Pull Request

There is Deprecated warning:

Deprecated
: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in
D:\www\joomla4\libraries\src\HTML\Helpers\Select.php

Expected result AFTER applying this Pull Request

No warning anymore.

avatar joomdonation joomdonation - open - 21 Mar 2022
avatar joomdonation joomdonation - change - 21 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2022
Category Libraries
avatar laoneo
laoneo - comment - 21 Mar 2022

I have tested this item successfully on b06ab32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37340.

avatar laoneo laoneo - test_item - 21 Mar 2022 - Tested successfully
avatar MacJoom
MacJoom - comment - 21 Mar 2022

I have tested this item successfully on b06ab32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37340.

avatar MacJoom MacJoom - test_item - 21 Mar 2022 - Tested successfully
avatar alikon alikon - change - 21 Mar 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37340.

avatar Quy Quy - change - 21 Mar 2022
Labels Added: ?
avatar bembelimen bembelimen - change - 24 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-24 20:59:53
Closed_By bembelimen
Labels Added: ? PHP 8.x
avatar bembelimen bembelimen - close - 24 Mar 2022
avatar bembelimen bembelimen - merge - 24 Mar 2022
avatar bembelimen
bembelimen - comment - 24 Mar 2022

Thx

Add a Comment

Login with GitHub to post a comment