? ? PHP 8.x Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
21 Mar 2022

Summary of Changes

In PHP 8.1, the return value must be a string, otherwise we get a null deprecated message.

Testing Instructions

Open the url /index.php?option=com_users&view=login

Actual result BEFORE applying this Pull Request

The following error is in the source of the page:
Deprecated: base64_encode(): Passing null to parameter #1 ($string) of type string is deprecated in /components/com_users/tmpl/login/default_login.php on line 112

Expected result AFTER applying this Pull Request

No error.

avatar laoneo laoneo - open - 21 Mar 2022
avatar laoneo laoneo - change - 21 Mar 2022
Status New Pending
avatar laoneo laoneo - change - 21 Mar 2022
Title
[4.1] Do not json decone return in login view
[4.1] Do not json decode return in login view
avatar laoneo laoneo - edited - 21 Mar 2022
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2022
Category Front End com_users
avatar laoneo laoneo - change - 21 Mar 2022
Title
[4.1] Do not json decode return in login view
[4.1] Json decode can't handle null in login view
avatar laoneo laoneo - edited - 21 Mar 2022
avatar joomdonation
joomdonation - comment - 21 Mar 2022

I have tested this item successfully on 79457a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37336.

avatar joomdonation joomdonation - test_item - 21 Mar 2022 - Tested successfully
avatar alikon
alikon - comment - 21 Mar 2022

I have tested this item successfully on 79457a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37336.

avatar alikon alikon - test_item - 21 Mar 2022 - Tested successfully
avatar alikon alikon - change - 21 Mar 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37336.

avatar Quy Quy - change - 21 Mar 2022
Labels Added: ?
avatar bembelimen bembelimen - change - 24 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-24 21:11:49
Closed_By bembelimen
Labels Added: ? PHP 8.x
avatar bembelimen bembelimen - close - 24 Mar 2022
avatar bembelimen bembelimen - merge - 24 Mar 2022
avatar bembelimen
bembelimen - comment - 24 Mar 2022

Thx

Add a Comment

Login with GitHub to post a comment