Feeling Lucky
?
?
PHP 8.x
[#37337] - [4.1] Check if attributes have a value before trimming in menu table
- Fixed in Code Base
- 7 Apr 2022
- Medium
- Build: 4.1-dev
- # 37337
- Diff
- Digital-Peak:j4/menu/table-81
User tests: Successful: Unsuccessful:
Summary of Changes
The menu table adds some checks if the values are empty. On PHP 8.1 these checks do throw a deprecated message when the value is null. For example on:
trim(): Passing null to parameter 1 ($string) of type string is deprecated in /libraries/src/Table/Menu.php on line 128
This happens only when doing a discover install with DPDocker, so it can be merged as code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
alikon
- comment
- 21 Mar 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37337.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 21 Mar 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37337.
bembelimen
- comment
- 24 Mar 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37337.
bembelimen
- comment
- 24 Mar 2022
| Labels |
Added:
?
?
?
PHP 8.x
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-07 00:30:30 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Removed:
?
|
||
bembelimen
- comment
- 7 Apr 2022
Thx
I have tested this item✅ successfully on deba857
Confirm the issue by installing an extension and check PHP error logs. This PR does solves the issue, so I gave it a successful test
Personal, I would change the code a bit to:
OR:
Also, during installation, the only line which is having issue is line 128. The changes for other lines are just for consistency only (data for the other fields are populated in already).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37337.