? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Mar 2022

When you preview a template an outline chrome is displayed around each module
To ensure that you can see all available module positions even if there is no published module in that position a dummy module is created.

This PR tweaks that so that a dummy module is only created if there is no module published in the position

before

image

After

image

avatar brianteeman brianteeman - open - 21 Mar 2022
avatar brianteeman brianteeman - change - 21 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2022
Category Libraries
avatar MacJoom
MacJoom - comment - 21 Mar 2022

I have tested this item successfully on 3cb7a70


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37335.

avatar MacJoom MacJoom - test_item - 21 Mar 2022 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 21 Mar 2022

I have tested this item successfully on 3cb7a70


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37335.

avatar ChristineWk ChristineWk - test_item - 21 Mar 2022 - Tested successfully
avatar Quy Quy - change - 21 Mar 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 21 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37335.

avatar brianteeman brianteeman - change - 1 Apr 2022
Labels Added: ?
avatar Quy
Quy - comment - 2 Apr 2022

Thanks

avatar Quy Quy - change - 2 Apr 2022
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2022-04-02 01:19:17
Closed_By Quy
avatar Quy Quy - close - 2 Apr 2022
avatar Quy Quy - change - 2 Apr 2022
Status Closed New
Closed_Date 2022-04-02 01:19:17
Closed_By Quy
Labels Removed: ?
avatar Quy Quy - change - 2 Apr 2022
Status New Pending
avatar Quy Quy - reopen - 2 Apr 2022
avatar Quy Quy - change - 2 Apr 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-02 04:13:37
Closed_By Quy
avatar Quy Quy - close - 2 Apr 2022
avatar Quy Quy - merge - 2 Apr 2022

Add a Comment

Login with GitHub to post a comment