? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Shubhamverma2796
Shubhamverma2796
14 Mar 2022

Summary of Changes

Changed button state on the basis of checkbox value.

Testing Instructions

  1. System-->Update-->Joomla.
  2. Check that the "Start button" is disabled by default after applying the patch.
  3. Click on the checkbox and make sure that the "Start button" is getting enabled/disabled on the basis of checkbox value.

Actual result BEFORE applying this Pull Request

"Start Button" is always active irrespective of the checkbox value.

Expected result AFTER applying this Pull Request

"Start Button" gets enabled/disabled on the basis of checkbox value.

avatar Shubhamverma2796 Shubhamverma2796 - open - 14 Mar 2022
avatar Shubhamverma2796 Shubhamverma2796 - change - 14 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2022
Category JavaScript Repository NPM Change Layout
avatar Shubhamverma2796 Shubhamverma2796 - change - 14 Mar 2022
Title
changing button state on the checkbox value
Changed the "Start Update" button state on the basis of checkbox value
avatar Shubhamverma2796 Shubhamverma2796 - edited - 14 Mar 2022
avatar Shubhamverma2796 Shubhamverma2796 - change - 14 Mar 2022
Labels Added: NPM Resource Changed ?
avatar richard67
richard67 - comment - 14 Mar 2022

@Shubhamverma2796 Hasn't this been solved already for 4.2 with your merged PR #36860 ???

avatar Quy
Quy - comment - 14 Mar 2022

It is a different page #36860 (comment). PR #36860 fixed the manual upload package page.

avatar richard67
richard67 - comment - 14 Mar 2022

And why is the other one for 4.2-dev and this one for 4.1-dev?

avatar richard67
richard67 - comment - 14 Mar 2022

And why is it in draft status?

avatar richard67
richard67 - comment - 15 Mar 2022

@Shubhamverma2796 Is it by purpose that this PR is still in draft status? Or is that by mistake? If the latter, you can change it by using the "Ready for review" button at the bottom of your PR. I think people will not spend time for testing as long as it is in draft status.

avatar Shubhamverma2796
Shubhamverma2796 - comment - 15 Mar 2022

@Shubhamverma2796 Is it by purpose that this PR is still in draft status? Or is that by mistake? If the latter, you can change it by using the "Ready for review" button at the bottom of your PR. I think people will not spend time for testing as long as it is in draft status.

Actually I opened the pr but later I realised that it is not the right fix so I changed it to draft. I am working on it.

avatar richard67
richard67 - comment - 15 Mar 2022

Ah, ok, thanks for the feedback.

avatar coolcat-creations
coolcat-creations - comment - 23 Mar 2022

Thank you for this PR but could we just remove the checkbox as its useless in my opinion. It just creates a barrier and it will not really educate people to backup.

avatar brianteeman
brianteeman - comment - 23 Mar 2022

It just creates a barrier

As intended so that they stop and think

and it will not really educate people to backup.

Based on ?

avatar coolcat-creations
coolcat-creations - comment - 23 Mar 2022

Based on comments here: #35583 and here: #36151 (you even liked the suggestion to remove the checkbox back then)

avatar Quy
Quy - comment - 23 Mar 2022

Based on comments here: #35583 and here: #36151 (you even liked the suggestion to remove the checkbox back then)

Please test PR #36531.

avatar Shubhamverma2796
Shubhamverma2796 - comment - 23 Mar 2022

Thank you for this PR but could we just remove the checkbox as its useless in my opinion. It just creates a barrier and it will not really educate people to backup.

so should I remove the checkbox?

avatar richard67
richard67 - comment - 23 Mar 2022

Thank you for this PR but could we just remove the checkbox as its useless in my opinion. It just creates a barrier and it will not really educate people to backup.

so should I remove the checkbox?

@Shubhamverma2796 As long as it is just an opinion in a discussion and not supported by a huge number of people, there is no need to remove the check box.

@coolcat-creations Would Nik's PR #36531 be a way? Beside other changes it makes the presence of the check boxes configurable.

avatar coolcat-creations
coolcat-creations - comment - 24 Mar 2022

@richard67 I have to check - it's a long read , thank you for directing me to this PR :)

avatar Quy
Quy - comment - 25 Mar 2022

@Shubhamverma2796 This probably should be rebased for v4.2 as @richard67 stated. Also why not use disabled attribute like you did with #36860?

avatar Shubhamverma2796
Shubhamverma2796 - comment - 25 Mar 2022

Not using disabled attribute because :

  1. There is no disabled attribute for anchor tag like this(a href="#" disabled") . Therefore, in order to use the disabled attribute, I will need to change the anchor tag to the button tag, which will cause problems for other empty states. For example: "Add your first article " will stop working.
  2. Even if I do use the button tag and add the disabled attribute, then initially, I need to set disabled=true because initially, the checkbox will be unchecked so that the button must be disabled. Again, this will cause problems for other states, ex: the "Add your first article" button will become disabled making it inaccessible.

I first used the disabled attribute but later faced these problems therefore added the disabled to the class only. I took all the steps as per my understanding, please correct me if I'm wrong.

avatar Shubhamverma2796 Shubhamverma2796 - change - 29 Mar 2022
Labels Added: ?
Removed: ?
avatar Quy
Quy - comment - 30 Mar 2022

I have tested this item successfully on fbf3353


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37270.

avatar Quy Quy - test_item - 30 Mar 2022 - Tested successfully
avatar pritam825
pritam825 - comment - 15 Apr 2022

I have tested this item successfully on fbf3353


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37270.

avatar pritam825 pritam825 - test_item - 15 Apr 2022 - Tested successfully
avatar Quy Quy - change - 15 Apr 2022
The description was changed
Status Pending Ready to Commit
avatar Quy
Quy - comment - 15 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37270.

avatar Quy Quy - edited - 15 Apr 2022
avatar fancyFranci fancyFranci - change - 16 Apr 2022
Labels Added: ?
avatar roland-d roland-d - change - 26 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-26 18:05:20
Closed_By roland-d
avatar roland-d roland-d - close - 26 Apr 2022
avatar roland-d roland-d - merge - 26 Apr 2022
avatar roland-d
roland-d - comment - 26 Apr 2022

Thanks everybody

Add a Comment

Login with GitHub to post a comment