User tests: Successful: Unsuccessful:
Changed button state on the basis of checkbox value.
"Start Button" is always active irrespective of the checkbox value.
"Start Button" gets enabled/disabled on the basis of checkbox value.
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change Layout |
Title |
|
Labels |
Added:
NPM Resource Changed
?
|
It is a different page #36860 (comment). PR #36860 fixed the manual upload package page.
And why is the other one for 4.2-dev and this one for 4.1-dev?
And why is it in draft status?
@Shubhamverma2796 Is it by purpose that this PR is still in draft status? Or is that by mistake? If the latter, you can change it by using the "Ready for review" button at the bottom of your PR. I think people will not spend time for testing as long as it is in draft status.
@Shubhamverma2796 Is it by purpose that this PR is still in draft status? Or is that by mistake? If the latter, you can change it by using the "Ready for review" button at the bottom of your PR. I think people will not spend time for testing as long as it is in draft status.
Actually I opened the pr but later I realised that it is not the right fix so I changed it to draft. I am working on it.
Ah, ok, thanks for the feedback.
Thank you for this PR but could we just remove the checkbox as its useless in my opinion. It just creates a barrier and it will not really educate people to backup.
It just creates a barrier
As intended so that they stop and think
and it will not really educate people to backup.
Based on ?
Thank you for this PR but could we just remove the checkbox as its useless in my opinion. It just creates a barrier and it will not really educate people to backup.
so should I remove the checkbox?
Thank you for this PR but could we just remove the checkbox as its useless in my opinion. It just creates a barrier and it will not really educate people to backup.
so should I remove the checkbox?
@Shubhamverma2796 As long as it is just an opinion in a discussion and not supported by a huge number of people, there is no need to remove the check box.
@coolcat-creations Would Nik's PR #36531 be a way? Beside other changes it makes the presence of the check boxes configurable.
@richard67 I have to check - it's a long read , thank you for directing me to this PR :)
@Shubhamverma2796 This probably should be rebased for v4.2 as @richard67 stated. Also why not use disabled
attribute like you did with #36860?
Not using disabled attribute because :
I first used the disabled attribute but later faced these problems therefore added the disabled to the class only. I took all the steps as per my understanding, please correct me if I'm wrong.
Labels |
Added:
?
Removed: ? |
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-26 18:05:20 |
Closed_By | ⇒ | roland-d |
Thanks everybody
@Shubhamverma2796 Hasn't this been solved already for 4.2 with your merged PR #36860 ???