? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Shreyas-SAS
Shreyas-SAS
14 Mar 2022

Pull Request for Issue # .

Summary of Changes

ISSUE:
previous README.md used improper copyright symbol rather than the officially accepted symbol.

Proposed CHANGES:
Changed Copyright symbol to increase professionalism of repository README.
Also enhances legitimacy in legal terms as previous symbol had no legal meaning.

Testing Instructions

Not Applicable.

Actual result BEFORE applying this Pull Request

Not Applicable.

Expected result AFTER applying this Pull Request

Not Applicable.

Documentation Changes Required

Proposed CHANGES:
Changed Copyright symbol to increase professionalism of repository README.
Also enhances legitimacy in legal terms as previous symbol had no legal meaning.

avatar Shreyas-SAS Shreyas-SAS - open - 14 Mar 2022
avatar Shreyas-SAS Shreyas-SAS - change - 14 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2022
Category Repository
avatar RickR2H
RickR2H - comment - 14 Mar 2022

I have tested this item successfully on 788719f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37271.

avatar RickR2H RickR2H - test_item - 14 Mar 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2022

Also enhances legitimacy in legal terms as previous symbol had no legal meaning.

you do not have to use the copyright symbol to obtain copyright protection for it; such protection is automatic.

avatar Shreyas-SAS
Shreyas-SAS - comment - 15 Mar 2022

you do not have to use the copyright symbol to obtain copyright protection for it; such protection is automatic.

I absolutely agree with you sir. Maybe I could not present it properly the first time.

What I meant is that the symbol shows more legitimacy than (C). On the other hand (C) is not a recognized symbol legally while copyright symbol is. Although the copyright act will still be active its always better to use a proper symbol on the Main Page of the repository.

avatar chmst
chmst - comment - 15 Mar 2022

I have tested this item successfully on 788719f

Nice :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37271.

avatar chmst chmst - test_item - 15 Mar 2022 - Tested successfully
avatar chmst chmst - change - 15 Mar 2022
Status Pending Ready to Commit
avatar chmst
chmst - comment - 15 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37271.

avatar Shreyas-SAS Shreyas-SAS - change - 16 Mar 2022
Labels Added: ? ?
avatar bembelimen
bembelimen - comment - 17 Mar 2022

If this should be merged, we still need the space after the copyright sign...but I'm yet not sure about it, as Joomla! uses (C) everywhere, so probably need a production decision to change it everywhere. (Pinging @nibra as if I remember correctly you handled the copyright somewhere in the past...)

avatar Shreyas-SAS
Shreyas-SAS - comment - 18 Mar 2022

If this should be merged, we still need the space after the copyright sign...but I'm yet not sure about it, as Joomla! uses (C) everywhere, so probably need a production decision to change it everywhere. (Pinging @nibra as if I remember correctly you handled the copyright somewhere in the past...)

@bembelimen @nibra @chmst

Of what I have noticed in the repository, most of the copyright symbol are set to (C) form, but I only wish to propose a change of these in the Documentation for the repository only and not the codes where it is usually present in the top of files as a comment.

The reason that the change was proposed only in the main Documentation file of the Repo (README.md) was due to its extensive visibility, Every person that visits the repo goes through the readme if not all documentation. In short its the face of the repository and I wanted to keep it as formal and clean as possible.

I would also like to add that I will be ready to take up the task of replacing each and every (C) in the repo with © after the date of 4th April since I am trying to get a project for GSOC currently and going through each file to find and replace (C) will not be feasible right now.

I am really thankful to you for your time and sorry if I brought you any trouble.

avatar laoneo laoneo - change - 18 Mar 2022
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2022-03-18 12:05:26
Closed_By laoneo
Labels Added: ?
avatar laoneo
laoneo - comment - 18 Mar 2022

Thanks for your contribution. Unfortunately we would like to keep it consistent in the repo and stay with the (C) syntax. If you want to change to the symbol it would require an adaption in every file where we use the doc header. So I'm closing this pr but there are many more issues where we can use your help.

avatar laoneo laoneo - close - 18 Mar 2022
avatar Shreyas-SAS
Shreyas-SAS - comment - 18 Mar 2022

Thanks for your contribution. Unfortunately we would like to keep it consistent in the repo and stay with the (C) syntax. If you want to change to the symbol it would require an adaption in every file where we use the doc header. So I'm closing this pr but there are many more issues where we can use your help.

I completely understand sir, I am really thankful for your time. I will try contributing to the community in every other way possible.

avatar nibra
nibra - comment - 18 Mar 2022

I agree that '(C)' should be displayed as '©' in the documention (i.e., *.md files), but the stress is on 'displayed'. When the document is used outside an editor or GitHub, like rendered on websites as documentation, '(C)' should be replaced with '©' on the fly by the rendering engine.

avatar Shreyas-SAS
Shreyas-SAS - comment - 18 Mar 2022

I agree that '(C)' should be displayed as '©' in the documention (i.e., *.md files), but the stress is on 'displayed'. When the document is used outside an editor or GitHub, like rendered on websites as documentation, '(C)' should be replaced with '©' on the fly by the rendering engine.

Oh. I really didn't know that it will be rendered in the website to a proper symbol.
I am thankful to you for haven taken out the time to respond to my silly commit. I have definitely learned a lot and will try my best to contribute something useful and feasible next time.
Thank you once again.

Add a Comment

Login with GitHub to post a comment