? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Mar 2022

Pull Request for Issue #37265 .

Summary of Changes

we don't need this variable as it is identical to $grid-gutter-width instead. This will make the css less "cassiopeia-specific"

After rebuilding the scss there is no difference in the resulting css

avatar brianteeman brianteeman - open - 14 Mar 2022
avatar brianteeman brianteeman - change - 14 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2022
Category Repository NPM Change
avatar hans2103
hans2103 - comment - 14 Mar 2022

I have tested this item successfully on 6d534f4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37266.

avatar hans2103 hans2103 - test_item - 14 Mar 2022 - Tested successfully
avatar Quy
Quy - comment - 14 Mar 2022

I have tested this item successfully on 6d534f4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37266.

avatar Quy Quy - test_item - 14 Mar 2022 - Tested successfully
avatar Quy Quy - change - 14 Mar 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 14 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37266.

avatar bembelimen
bembelimen - comment - 15 Mar 2022

In best case we get rid of all cassipeia specific variables, when possible.

avatar brianteeman brianteeman - change - 15 Mar 2022
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2022-03-15 15:26:23
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 15 Mar 2022

Add a Comment

Login with GitHub to post a comment