Feeling Lucky
No Code Attached Yet
[#37265] - cassiopeia-grid-gutter
- Closed
- 14 Mar 2022
- Medium
- Build: 4.1-dev
- # 37265
I'm looking at the scss for cassiopeia and I see that one of the most used variables is $cassiopeia-grid-gutter
However as the value of $cassiopeia-grid-gutter is $grid-gutter-width I can't see that we actually need this additional variable
Assuming that I am correct and we don't need this variable I propose to remove it and use grid-gutter-width instead. This will make the css less "cassiopeia-specific" and might even result in the need for less.
Happy to do the work but would like a sanity check from @hans2103 and/or @drmenzelit first that it is indeed a useless variable.
edit : I already did a search and replace and compared the generated css and the results are the same
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-14 10:06:26 |
| Closed_By | ⇒ | brianteeman |
brianteeman
- comment
- 14 Mar 2022
OK thanks for confirming I will submit the PR
History of these two variables:
PR [4.0] New Frontend (Aurora) Template #14864
add
PR [4.0] Move Aurora to CSS Grid #16810
add
PR [4.0] Update Bootstrap to beta-1 #17496
change
PR [4.0] Rename aurora #18418
rename Aurora to Cassiopeia
Commit? override Bootstrap 4 px sizes by em sizes
change pc => em
No changes afterwards.
The variable
$grid-gutter-widthis a Bootstrap 5 variable and set to 1.5rem in bootstrap itself.https://github.com/twbs/bootstrap/blob/a9a89debc7535a1c5857ced28c1002a2f682889f/scss/_variables.scss#L466
In Cassiopeia an override is created to change this variable to 1em.
I agree with the suggestion made by @brianteeman and replace
$cassiopeia-grid-gutterby$gtid-gutter-width