Feeling Lucky
?
NPM Resource Changed
?
[#37255] - [4.1] Remove the math.div deprecation
- Fixed in Code Base
- 17 Mar 2022
- Medium
- Build: 4.1-dev
- # 37255
- Diff
- dgrammatiko:4.1-dev-sass-deprecations
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Kinda replaces #36906 (no FA upgrade to v6)
Summary of Changes
- patch the font awesome files
- local fixes
Testing Instructions
- Apply this Pr's branch
- run npm ci
- Check that nothing is broken visually and there are no console deprecation when running any node (css related) cli command
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change JavaScript Repository |
| Labels |
Added:
NPM Resource Changed
?
|
||
brianteeman
- comment
- 12 Mar 2022
I have tested this item
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37255.
dgrammatiko
- comment
- 12 Mar 2022
Is it intentional that the joomla.asset.json files no longer have a version hash?
The hash is not generated automatically per npm ci, you need to run specifically npm run versioning. (the reason is because for development having to invalidate this hash every time you apply some changes in any of the css/js would be an extra step which will be a way slower workflow)
richard67
- comment
- 14 Mar 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37255.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 14 Mar 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37255.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-17 19:55:20 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 17 Mar 2022
Thx
I can confirm that the deprecation notices have now gone
Is it intentional that the joomla.asset.json files no longer have a version hash?Commented on the code where there is an error in your math