Feeling Lucky
?
NPM Resource Changed
?
[#37254] - [4.2] Add missing finder parameter
- Closed
- 14 Mar 2022
- Medium
- Build: 4.1-dev
- # 37254
- Diff
- bembelimen:4.2/finder-form-param
User tests: Successful: Unsuccessful:
Replacement for: #35967
Summary of Changes
Add the missing parameter to the menu/config
Testing Instructions
- Create a menu item for the finder
- Play around with the parameter "Show search form" in the menu and the config
Actual result BEFORE applying this Pull Request
- Parameter not given
Expected result AFTER applying this Pull Request
- Parameter there and working
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_associations com_banners com_cache com_categories com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages JavaScript com_media NPM Change |
bembelimen
- comment
- 14 Mar 2022
Agree, needs more than only the parameters. Can be taken over by s.o. if needed
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-14 04:37:47 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
| Category | Unit Tests Repository Administration com_associations com_banners com_cache com_categories com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages JavaScript com_media NPM Change | ⇒ | Administration com_finder Language & Strings Front End |
I have tested this item? unsuccessfully on b18576c
This option makes no sense to me.
It requires you to have a search module
If there are NO results then the link to "search again" is broken
Even if you then hide the search again link you would need to have the search module published on the search results page
Dont you need to update the db as well with the default value - otherwise the Use Global option doesnt work
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37254.