[#37220] - [4] Sort JConfig properties A-Z
- Closed
- 7 Mar 2022
- Medium
- Build: 4.1-dev
- # 37220
- Diff
- PhilETaylor:220306-a-z-config
User tests: Successful: Unsuccessful:
Summary of Changes
When saving Joomla Global Configuration, sort the properties of JConfig A-Z so that configuration.php gets written in a human reader friendly way.
SORT_STRING | SORT_FLAG_CASE is fully compatible with PHP versions Joomla 4 is is targeted at
Testing Instructions
Save Joomla global config - view contents of configuration.php
Actual result BEFORE applying this Pull Request
Semi-random ordering of properties, db crednetials no where near db host for example
Expected result AFTER applying this Pull Request
A-Z with natural case flagging (so M and m are close) to make it easier for humans to find the string they are interested in quicker.
Documentation Changes Required
None. Fully backward compatible.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
Semi-random ordering of properties, db crednetials no where near db host for example
I can not confirm this
alphabetical sorting is only useful if you already know the name of the variable you are looking for
This PR is A-z sorting not per category and not semi random.
It achieves its aim and is better than total random that is the current situation.
| Labels |
Added:
?
|
||
Go and visit real sites and view their configuration file - you will see I’m right. I open hundreds a month.
If you are manually editing this file, then there is a good chance that you already know why you are opening the file and you already know what you are looking for!
Go and visit real sites and view their configuration file - you will see I’m right. I open hundreds a month.
I pasted the results of three real sites.
The order they are stored in is defined here
That file is only used where installing Joomla and is then deleted. That is not the code used when saving Joomla global config
The semi random order is because the order is by luck depending on the order items are added to the $data array, which is also then modified further with no thought to ordering, and further merged with $prev array, and then by converting that array to a Registry object and then ultimately casting of the registry object to string here
So yeah, I call that semi-random ordering - it certainly not grouped like you think it is.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:34:29 |
| Closed_By | ⇒ | PhilETaylor |
I have tested this item✅ successfully on e21e9b6
Tested successfully in 4.1.1-dev of 6 March in Wampserver 3.2.7 using PHP 8.0.15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37220.