[#37219] - [4] Page of errors when trying to load deleted template file
- Closed
- 7 Mar 2022
- Medium
- Build: 4.1-dev
- # 37219
- Diff
- PhilETaylor:29345-missingtemplate
User tests: Successful: Unsuccessful:
Pull Request for Issue Page of errors when trying to load deleted template file. #29345
Summary of Changes
Check template exists before running off and attempting anything else
Testing Instructions
Try to edit a template that has been deleted using a bookmark or cached url in your browser (or try to hack yourself by loading an invalid template id) .
The easiest way to replicate is to go to edit the templates files
http://example.com/administrator/index.php?option=com_templates&view=templates
Select administrator
Click Atum Details and Files
gets you a url like this
https://example.com/administrator/index.php?option=com_templates&view=template&id=210&file=aG9tZQ==
Change 210 to lets say 666
Actual result BEFORE applying this Pull Request
A page of errors or more recently just bool
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Title |
|
||||||
Attempt to assign property xmldata on bool is the PHP exception.
sorry - wrong site. ignore my comments (will delete) - its late.
Maybe I confused you by having the debug on in one of the screenshots... I'll replace the screenshot...
I'll replace the screenshot...
Done.
I have tested this item
Tested successfully in 4.1.1-dev of 6 March using Wampserver 3.2.7 and PHP 8.0.15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37219.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:34:26 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
|
||
You totally miss the point.
What you are showing is a correct 404 page with debug mode on.
What this is fixing is a PHP Exception that is being raised, thus no, it is specific to this here, and no further changes are needed or planned. This is the same kind of fix as trying to load http://127.0.0.1/administrator/index.php?option=com_content&task=article.edit&id=2974628973456239845672 which is correctly handled and doesnt show a PHP exception (Error 0)