User tests: Successful: Unsuccessful:
Pull Request for Issue #31719
When you change your configuration for example
Joomla RETAINS your credentials in HIDDEN fields in Joomla global configuration and stores them in PLAIN TEXT in /configuration.php - but you don't know this because Joomla hides that fact from you.
A super admin, who has done one of the above actions is rightly assuming Joomla will discard the credentials as the credential input boxes are no longer shown to them.
Plus, why should Joomla retain - in plain text - credentials that it no longer needs to operate. This is an additional security issue should the site be compromised.
Same with outbound proxy.
Joomla stores forever the credentials of services no longer used, in plain text, in configuration.php
Joomla deletes the credentials of services no longer used
None. Fully backward compatible.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_config |
Labels |
Added:
?
|
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Are we sure that this is a good idea?
For example I setup smtp and confirm it is working but decide to check and see if sendmail is a better option. I decide it is not and now i have to find the details for smtp again.
This is a destructive change that is made without any notice to the user.
Plain text credentials should not be stored for disabled features. Basic security.
Plain text credentials should not be stored for disabled features. Basic security.
if someone can read that plain text then the smtp details are the least of your problems.
Iām sorry that you do not understand. This PR stands and is valid and correct implementation of basic security principles - for that reason alone it should be merged.
Labels |
Added:
?
|
This is a destructive change that is made without any notice to the user.
Hint. Tell the user before making a destructive change.
Well feel free to make a PR to give a message.
However I do not believe a message is needed and Joomla already makes other changes during save that are not communicated and my expectation as a user would be that my password would not be retained if I disabled the feature.
agree to disagree then. Just like your other pr
No you just love to disagree even when you are simply wrong. Luckily this is not your project and your opinion is only a single voice.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:34:32 |
Closed_By | ⇒ | PhilETaylor |
I have tested this itemā
successfully on b1d29ba
Tested successfully in 4.1.1-dev of 7 March in Wampserver 3.2.7 with PHP 8.0.15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37221.