? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
3 Jun 2014

Tracker

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33760&start=0

Description

addCustomTag is not a valid method for JDocumentRaw and generates an error if the URL contains "format=raw", which I use for displaying forms within an AJAX dialog (the form contains an editor widget).

Code by Dan Cogliano

avatar zero-24 zero-24 - open - 3 Jun 2014
avatar zero-24 zero-24 - change - 3 Jun 2014
Title
JEditor errors on addCustomTag() call when using raw document
[#33760] JEditor errors on addCustomTag() call when using raw document
avatar Kubik-Rubik
Kubik-Rubik - comment - 27 Jul 2014

Except the code style it is a good suggestion! Please update the PR, then we can accept it.

avatar zero-24
zero-24 - comment - 28 Jul 2014

thanks @b2z and @Kubik-Rubik CS is fixed now

avatar roland-d
roland-d - comment - 31 Jul 2014

@test: Successful, after applying the patch, the fatal error is gone.

avatar b2z
b2z - comment - 31 Jul 2014

@roland-d how did you test it?

avatar roland-d
roland-d - comment - 31 Jul 2014

@b2z There are 2 ways, first is having your own component that uses this option and second is to modify the banners component.

*Banners component
1. Edit the file administrator\components\com_banners\models\tracks.php and add these lines after line 473:

$editor = JEditor::getInstance('tinymce');
$editor->display();
  1. Open the URL http:///administrator/index.php?option=com_banners&view=tracks&format=raw
  2. You get some undefined warnings but they can be ignored because the editor is not completely instantiated. The last one is the fatal error: Fatal error: Call to undefined method JDocumentRaw::addCustomTag()
  3. Apply the patch
  4. Call the URL again and the error is gone.

That is how I tested it.

avatar Kubik-Rubik
Kubik-Rubik - comment - 31 Jul 2014
avatar brianteeman brianteeman - change - 1 Aug 2014
Labels Added: ?
avatar Bakual Bakual - change - 8 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-08 20:55:01
avatar Bakual Bakual - close - 8 Aug 2014
avatar Bakual Bakual - close - 8 Aug 2014
avatar zero-24 zero-24 - head_ref_deleted - 9 Aug 2014
avatar Sophist-UK Sophist-UK - reference | 73a6400 - 7 Oct 14

Add a Comment

Login with GitHub to post a comment