[#3715] - Protostar: Load default icomoon set
- Closed
- 11 Jul 2014
- Medium
- Build: staging
- # 3715
- Diff
- 810:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This CSS rules are actually coming from a {LESS} file. In that case it's this import: https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/less/template.less#L86
It imports the file https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/less/icomoon.less.
So the Icomoon stuff should actually be exactly the same as the one in the icomoon.css you want to load.
Loading the icomoon.css file as a separate entity doesn't make much sense to me when we can include it automatically in the main template.css file.
If you want to make changes to it, you would need to adjust the LESS files and afterwards run /build/generatecss.php so the template.css files get updated.
As mentioned by @Bakual the IcoMoon CSS is added to the ProtoStar CSS using LESS. So removing it from CSS makes no sense. I think the reason why this PR was placed was that if a third party extension (like Kunena) uses IcoMoon, and the template also uses the IconMoon - but both use a different IcoMoon version, this leads to conflicts. Understandable, but removing the CSS is no option. There is no other option than to rebuild the CSS using LESS.
I'm sorry to say that this pull request is best closed.
Closed
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-11 12:54:54 |
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33818&start=500