? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Feb 2022

This PR removes the non-existent tooltip option

pr for #36938

avatar brianteeman brianteeman - open - 22 Feb 2022
avatar brianteeman brianteeman - change - 22 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2022
Category Administration Language & Strings Front End Plugins
avatar laoneo
laoneo - comment - 22 Feb 2022

Thanks @brianteeman. Are the other two options still working?

avatar brianteeman
brianteeman - comment - 22 Feb 2022

of course

avatar laoneo laoneo - change - 22 Feb 2022
Title
[4.1] Media Fields
[4.1] Remove invalid tooltip option in media field
avatar laoneo laoneo - edited - 22 Feb 2022
avatar tecpromotion
tecpromotion - comment - 5 Mar 2022

I have tested this item successfully on 936ed17

database value for fieldparams before patch
{"directory":"","preview":"tooltip","image_class":""}

database value for fieldparams after apply patch
{"directory":"","preview":"tooltip","image_class":""}

database value for fieldparams after save the field
{"directory":"","preview":"","image_class":""}

This should fit, because even without saving the field again, the value "tooltip" has no effect.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37115.

avatar tecpromotion tecpromotion - test_item - 5 Mar 2022 - Tested successfully
avatar pabloarias
pabloarias - comment - 18 Mar 2022

I have tested this item successfully on 936ed17

Tested in Joomla 4.1.1-dev with PHP 8.0.15.

Tooltip option was removed. Inline and No options work fine.

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37115.

avatar pabloarias pabloarias - test_item - 18 Mar 2022 - Tested successfully
avatar laoneo
laoneo - comment - 18 Mar 2022

@brianteeman do you want to add the comment, mentioned by @Quy?

avatar brianteeman
brianteeman - comment - 18 Mar 2022

I am happy with the PR as it is

avatar laoneo laoneo - change - 19 Mar 2022
Status Pending Ready to Commit
avatar laoneo laoneo - change - 19 Mar 2022
Status Ready to Commit Pending
avatar laoneo laoneo - change - 19 Mar 2022
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 19 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37115.

avatar brianteeman brianteeman - change - 1 Apr 2022
Labels Added: ? Language Change ?
avatar Quy Quy - change - 2 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-02 00:00:13
Closed_By Quy
avatar Quy Quy - close - 2 Apr 2022
avatar Quy Quy - merge - 2 Apr 2022
avatar Quy
Quy - comment - 2 Apr 2022

Thanks

Add a Comment

Login with GitHub to post a comment