[#37112] - [4.1]Advanced Search > parameters > Sort order > price
- Closed
- 25 Mar 2022
- Very low
- Build: 4.1
- # 37112
In Backend > Advanced search parameters, there is an option to sort results based on different options.
One of them is "Sort by Price", which is based on a field in table #finder_links called "list_price".
Is this parameter useful ? I've checked every script in Joomla, and there is no need of this option, as it is not used anywhere in Joomla. It seems to be a left over of an old Joomla version (2.5 ?)
This is my first PullRequest, asked by Marc Dechevre to do it. Please be kind, hoping I'm not missing any important milestone/haveto.
Best
Philippe
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
This is my first PullRequest, asked by Marc Dechevre to do it.
@pcombet-adosis This here is an issue report, not a pull request. That's why it's listed here https://github.com/joomla/joomla-cms/issues and not here https://github.com/joomla/joomla-cms/pulls . A pull request includes code changes. Was your intention to make a pull request?
@richard67 those variables list_price and sale_list are NOT used anymore in Joomla. Brian Teeman confirmed and pointed me to some features that were abandoned back in 2013 (9 years). My idea via a PullRequest was to clean the database, the backend option (not used), the SQL files that create the columns in J!, so that we lighten the code. That was an idea, Behind this action, I'm trying to get used to the debugging/PR process, as this is my first attempt to improve J! I do not really know if the idea is good but it's worth trying it ;-)
Philippe
@pcombet-adosis I still don't understand why you write as if you had created a pull request already but you have only created an issue report.
I did NOT confirm they are not being used.
@pcombet-adosis I still don't understand why you write as if you had created a pull request already but you have only created an issue report.
@richard67 Sorry I'm not used to the exact vocabulary of testing/coding/improving software. My intention was to mention that those options in the backend are NOT used/useful in J!. I have checked all the J! files, and it not used anywhere. Thus creating an issue woukld bring the topic on the table, so that maybe others coders/volunteers could analyse it to lighten J! code. The PullRequest was a suggestion from MarcDechevre, but sorry if I'm mistaken, I'm not used to this new vocab. I'm a Marketing man, not much a coder. Best, Philippe
Please see #35993 (comment) for context of possible usage.
Yes, the price field currently is not used, but we have it and it would allow shops to use smart search as well. I don't think we want to remove that.
@pcombet-adosis Are you ok with the above explanations now? Can we (or you can yourself) close this issue as expected behaviour?
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-25 11:14:28 |
| Closed_By | ⇒ | pcombet-adosis |
Please read