[#37116] - [4.1] Module "Articles - Categories" - Make the category selection optional
- Fixed in Code Base
- 17 Mar 2022
- Medium
- Build: 4.1-dev
- # 37116
- Diff
- Bakual:4_mod_articles_categories
User tests: Successful: Unsuccessful:
The module "Articles - Categories" requires to select a parent category. But that means you can't have the module show all categories, you can only show a subset.
I think this is a requirement which is not needed. The code itself already falls back to "root" if no category is selected.
Summary of Changes
Removing the "required" flag from the parent category field.
Testing Instructions
Test the module "Articles - Categories" and make especially sure nothing breaks when no category is selected.
Actual result BEFORE applying this Pull Request
You always need to select a category and the module shows only subset of the article categories.
Expected result AFTER applying this Pull Request
You don't need to select a category and the module can show all categories.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37116.
I think the history on this code needs to be checked carefully. I'm sure there must be a reason. It is possibly related to multilingual
I have tested this item
Tested successfully in Joomla 4.1.1-dev of 23 February in Wampserver 3.2.7 using PHP 8.0.15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37116.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37116.
| Labels |
Added:
?
|
||
Why should it not work? I didn't change anything in the formfield.
But you are changing back something which was introduced on purpose. If that still works, then all is fine. Just wanted to double check before merging.
But you are changing back something which was introduced on purpose.
which is a big red warning flag to me
I honestly doubt that it indeed was changed on purpose.
To me it looks more like copy-paste, because in other places it indeed has to be (and was before) required.
But here I couldn't find any issues with it being optional. And yep, of course the formfield can handle empty values.
Also, as I already wrote in the PR description, the code of the module already handles the case when no category is selected. I didn't had to change anything there.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-17 21:09:15 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item✅ successfully on b8c2a08
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37116.