[#37096] - Fix changed behavior of getAuthorisedViewLevels
- Fixed in Code Base
- 7 Mar 2022
- Medium
- Build: 4.1-dev
- # 37096
- Diff
- Fedik:fix-user-viewlvl
User tests: Successful: Unsuccessful:
Summary of Changes
After PR #36432 $user->->getAuthorisedViewLevels() now return Associative array,
that may lead to unexpected bugs when code relies on non Associative array.
This PR make sure the array is non associative
Testing Instructions
In index.php of template add:
dump(Joomla\Utilities\ArrayHelper::isAssociative($app->getIdentity()->getAuthorisedViewLevels()));
Actual result BEFORE applying this Pull Request
Result is true.
Expected result AFTER applying this Pull Request
Result is false.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
bug
|
||
@bembelimen adding this as a release blocker as it's a API B/C break
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37096.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37096.
| Labels |
Added:
?
Release Blocker
|
||
| Labels |
Added:
?
|
||
@bembelimen adding this as a release blocker as it's a API B/C break
Why a BC break?
Why a BC break?
Because return value is changed
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 12:31:35 |
| Closed_By | ⇒ | bembelimen |
Good find, thx.
I have tested this item✅ successfully on c7d86af
Tested successfully in 4.1.1-dev of 22 February in Wampserver 3.2.7 using PHP 8.0.15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37096.