[#37095] - [4.2] Inject the db into the MVC layer
- Fixed in Code Base
- 14 Apr 2022
- Medium
- Build: 4.2-dev
- # 37095
- Diff
- Digital-Peak:j4/db/inject
User tests: Successful: Unsuccessful:
Summary of Changes
Injects the database instance into the model. So we don't have to rely on the global db anymore. Additionally it deprecates the use of the database in the model constructor and uses the aware interface and trait from the db package.
Testing Instructions
- Browse around in the back end and front end of Joomla
- Open the back end user list view
- Open the back end modules list view
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Administration com_config com_installer com_menus com_modules com_users Front End com_content Libraries |
This looks wrong to me. The only place that should be database aware is the model. All controller and views database queries should be eventually moved into the model. not be made database aware
I agree too, and the problem is that there are queries which do not actually fit into a model, for example against the extensions table. I mean I can move all of them to the model of the view, but would be nicer to have them just from the beginning on the right place.
| Category | Libraries Administration com_config com_installer com_menus com_modules com_users Front End com_content | ⇒ | Administration com_config Libraries |
This looks better. I don't think that factory should be databaseaware. Just the model. But definitely better than what we had before.
True, removed the interface.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37095.
| Category | Libraries Administration com_config | ⇒ | Administration com_config External Library Composer Change Libraries |
| Labels |
Added:
Composer Dependency Changed
|
||
| Category | Libraries Administration com_config External Library Composer Change | ⇒ | Administration com_config External Library Composer Change Libraries Unit Tests |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-14 11:38:10 |
| Closed_By | ⇒ | roland-d |
Thank you everybody
This looks wrong to me. The only place that should be database aware is the model. All controller and views database queries should be eventually moved into the model. not be made database aware