PBF ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
19 Feb 2022

Pull Request for pr #37095.

Summary of Changes

Injects the database instance into the forms and form fields.

Testing Instructions

  • In the file /libraries/src/Form/Form.php add the following code after line 1629:
    echo 'NOT INJECTED!';die;
  • Open the article form.

Actual result BEFORE applying this Pull Request

All is working.

Expected result AFTER applying this Pull Request

All is working, the form loads and "NOT INJECTED!" is not displayed on the page.

avatar laoneo laoneo - open - 19 Feb 2022
avatar laoneo laoneo - change - 19 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2022
Category Administration com_categories com_config com_contact com_content com_fields com_finder com_installer com_menus com_messages com_modules
avatar laoneo laoneo - change - 19 Feb 2022
The description was changed
avatar laoneo laoneo - edited - 19 Feb 2022
avatar laoneo laoneo - change - 10 Mar 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2022
Category Administration com_categories com_config com_contact com_content com_fields com_finder com_installer com_menus com_messages com_modules Administration com_categories com_config com_contact com_content com_fields com_finder com_menus com_messages com_modules com_newsfeeds
avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2022
Category Administration com_categories com_config com_contact com_content com_fields com_finder com_menus com_messages com_modules com_newsfeeds Administration com_categories com_config com_contact com_content com_fields com_finder com_menus com_messages com_newsfeeds com_plugins com_workflow External Library Composer Change
avatar laoneo laoneo - change - 10 Mar 2022
Labels Added: Composer Dependency Changed
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2022
Category Administration com_categories com_config com_contact com_content com_fields com_finder com_menus com_messages com_newsfeeds com_plugins com_workflow External Library Composer Change Administration com_categories com_config com_contact com_content com_fields com_finder com_menus com_messages com_newsfeeds com_plugins com_workflow Libraries
avatar laoneo laoneo - change - 14 Apr 2022
Labels Removed: Composer Dependency Changed
f16b86f 14 Apr 2022 avatar laoneo rules
avatar brianteeman
brianteeman - comment - 20 Apr 2022

From the information provided its impossible to test.

avatar laoneo
laoneo - comment - 20 Apr 2022

Just open the article form, either in the back end and front end. Make sure there is no error. As this change injects the database into the form, every form field is affected and no "Database must be set, this will not be caught anymore in 5.0." message is added to the deprecate log.

avatar laoneo laoneo - change - 22 Apr 2022
The description was changed
avatar laoneo laoneo - edited - 22 Apr 2022
avatar laoneo laoneo - change - 22 Apr 2022
The description was changed
avatar laoneo laoneo - edited - 22 Apr 2022
avatar laoneo
laoneo - comment - 22 Apr 2022

Updated the testing instructions.

avatar laoneo laoneo - change - 10 May 2022
Labels Added: PBF
avatar roland-d roland-d - change - 10 May 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-10 16:33:19
Closed_By roland-d
avatar roland-d roland-d - close - 10 May 2022
avatar roland-d roland-d - merge - 10 May 2022
avatar roland-d
roland-d - comment - 10 May 2022

Thank you.

Add a Comment

Login with GitHub to post a comment