? Release Blocker NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
17 Feb 2022

Pull Request for Issue #37061

Summary of Changes

  • Make sure that tinyMCE is actually loaded for the builder and that the builder is initiated after DOMContentLoaded
  • Tweak the logic to pick the right language (auto/user selected)

Testing Instructions

Check the issue

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

No bug fix, regression

avatar dgrammatiko dgrammatiko - open - 17 Feb 2022
avatar dgrammatiko dgrammatiko - change - 17 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2022
Category JavaScript Repository NPM Change Layout
avatar dgrammatiko dgrammatiko - change - 17 Feb 2022
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2022
Category JavaScript Repository NPM Change Layout JavaScript Repository NPM Change Layout Front End Plugins
377d91c 17 Feb 2022 avatar dgrammatiko meh
avatar dgrammatiko dgrammatiko - change - 17 Feb 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 17 Feb 2022
avatar richard67
richard67 - comment - 17 Feb 2022

@dgrammatiko Do I understand right that this PR fixes only a part of the issue? If so, could you mention that at the top of the description by adding something like „(part)“ to the line with the reference to the issue?

avatar infograf768
infograf768 - comment - 17 Feb 2022

This PR does solve all for me i.e. automatic lang and fields.

avatar infograf768 infograf768 - test_item - 17 Feb 2022 - Tested successfully
avatar infograf768
infograf768 - comment - 17 Feb 2022

I have tested this item successfully on 377d91c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.

avatar richard67
richard67 - comment - 17 Feb 2022

This PR does solve all for me i.e. automatic lang and fields.

@infograf768 So your issue could be closed? Can you do that?

avatar infograf768
infograf768 - comment - 17 Feb 2022

done

avatar brianteeman brianteeman - test_item - 17 Feb 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Feb 2022

I have tested this item successfully on 377d91c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.

avatar richard67 richard67 - change - 17 Feb 2022
Status Pending Ready to Commit
avatar richard67 richard67 - edited - 17 Feb 2022
avatar richard67
richard67 - comment - 17 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.

avatar dgrammatiko dgrammatiko - change - 23 Feb 2022
Labels Added: ?
avatar bembelimen
bembelimen - comment - 3 Mar 2022

@brianteeman and @infograf768 would you kindly please re-test?

avatar bembelimen bembelimen - change - 8 Mar 2022
Status Ready to Commit Pending
avatar bembelimen bembelimen - change - 8 Mar 2022
Status Pending Ready to Commit
avatar bembelimen bembelimen - change - 8 Mar 2022
Status Ready to Commit Pending
avatar bembelimen
bembelimen - comment - 8 Mar 2022

Revert RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.

avatar bembelimen bembelimen - change - 8 Mar 2022
Labels Added: Release Blocker
Removed: ?
avatar richard67
richard67 - comment - 12 Mar 2022

@brianteeman @infograf768 Could you test again? Thanks in advance.

avatar brianteeman
brianteeman - comment - 13 Mar 2022

Tinymce not loaded n the builder

image

avatar brianteeman
brianteeman - comment - 13 Mar 2022

I have tested this item 🔴 unsuccessfully on a71ee37


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.

avatar brianteeman brianteeman - test_item - 13 Mar 2022 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 13 Mar 2022

I have tested this item successfully on b422504


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.

avatar brianteeman brianteeman - test_item - 13 Mar 2022 - Tested successfully
avatar richard67
richard67 - comment - 13 Mar 2022

I have just tested with automatic language detection and with manual language. It works all fine in the editor (backend and frontend).

But in the plugin options the manual language seems not to work for me with this PR applied. The editor elements in the plugin's settings are shown in the current backend language when I have switched off the automatic language detection and chosen a different language as editor language some time before.

@brianteeman Can you confirm that?

avatar richard67
richard67 - comment - 13 Mar 2022

P.S.: I mean the parts marked with red in this comment: #37061 (comment) . Without this PR they are in English, with this PR they are in current backend language regardless of the automatic language detection being switched on or off.

avatar dgrammatiko
dgrammatiko - comment - 13 Mar 2022

Without this PR they are in English, with this PR they are in current backend language regardless of the automatic language detection being switched on or off.

I think this is the expected behaviour. The plugin adapts to the backend language for its own options. The language settings are affecting only the tinMCE (the editor either in the front end or back end).

EDIT unless if that wasn't the previous behaviour so then we have to match what was there

EDIT2: This is expected behaviour as the language for the builder defaults to the current backend language according to the code:

// Check for TinyMCE language file
$language = Factory::getLanguage();
$languageFile1 = 'media/vendor/tinymce/langs/' . $language->getTag() . (JDEBUG ? '.js' : '.min.js');
$languageFile2 = 'media/vendor/tinymce/langs/' . substr($language->getTag(), 0, strpos($language->getTag(), '-')) . (JDEBUG ? '.js' : '.min.js');
$data['languageFile'] = '';
if (file_exists(JPATH_ROOT . '/' . $languageFile1))
{
$data['languageFile'] = $languageFile1;
}
elseif (file_exists(JPATH_ROOT . '/' . $languageFile2))
{
$data['languageFile'] = $languageFile2;
}
$this->layoutData = $data;

avatar brianteeman
brianteeman - comment - 13 Mar 2022

@richard67 that is the expected behaviour

avatar richard67
richard67 - comment - 13 Mar 2022

I have tested this item successfully on b422504


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.

avatar richard67 richard67 - test_item - 13 Mar 2022 - Tested successfully
avatar richard67 richard67 - change - 13 Mar 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 13 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.

8942e88 18 Mar 2022 avatar dgrammatiko Dep
avatar dgrammatiko dgrammatiko - change - 18 Mar 2022
Labels Added: ?
avatar bembelimen bembelimen - change - 18 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-18 07:54:02
Closed_By bembelimen
avatar bembelimen bembelimen - close - 18 Mar 2022
avatar bembelimen bembelimen - merge - 18 Mar 2022
avatar bembelimen
bembelimen - comment - 18 Mar 2022

Thx

Add a Comment

Login with GitHub to post a comment