Joomla! Issue Tracker | Joomla! CMS #37075 - [4.1.1][regression] TinyMCE language misbehaving

? Release Blocker NPM Resource Changed ?

Fixed in Code Base
18 Mar 2022
Medium
Build: 4.1-dev
# 37075
Diff
dgrammatiko:4.1-dev-tiny_lang

Pending

User tests: Successful: Unsuccessful:

dgrammatiko
17 Feb 2022

Pull Request for Issue #37061

Summary of Changes

Make sure that tinyMCE is actually loaded for the builder and that the builder is initiated after DOMContentLoaded
Tweak the logic to pick the right language (auto/user selected)

Testing Instructions

Check the issue

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

No bug fix, regression

291be9a 17 Feb 2022

Fix tiny

ce60a0e 17 Feb 2022

Merge branch '4.1-dev' of github.com:joomla/joomla-cms into 4.1-dev-tiny_lang

dgrammatiko - open - 17 Feb 2022

dgrammatiko - change - 17 Feb 2022

Status

New

⇒

Pending

joomla-cms-bot - change - 17 Feb 2022

Category

JavaScript Repository NPM Change Layout

⇒

JavaScript Repository NPM Change Layout Front End Plugins

377d91c 17 Feb 2022

meh

dgrammatiko - change - 17 Feb 2022

The description was changed

dgrammatiko - edited - 17 Feb 2022

richard67 - comment - 17 Feb 2022

@dgrammatiko Do I understand right that this PR fixes only a part of the issue? If so, could you mention that at the top of the description by adding something like „(part)“ to the line with the reference to the issue?

infograf768 - comment - 17 Feb 2022

This PR does solve all for me i.e. automatic lang and fields.

infograf768 - test_item - 17 Feb 2022 - Tested successfully

infograf768 - comment - 17 Feb 2022

I have tested this item ✅ successfully on 377d91c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.}

richard67 - comment - 17 Feb 2022

This PR does solve all for me i.e. automatic lang and fields.

@infograf768 So your issue could be closed? Can you do that?

infograf768 - comment - 17 Feb 2022

done

brianteeman - test_item - 17 Feb 2022 - Tested successfully

brianteeman - comment - 17 Feb 2022

I have tested this item ✅ successfully on 377d91c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.}

richard67 - change - 17 Feb 2022

Status

Pending

⇒

Ready to Commit

richard67 - edited - 17 Feb 2022

richard67 - comment - 17 Feb 2022

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.}

579ce6f 23 Feb 2022

Update tinymcebuilder.php

dgrammatiko - change - 23 Feb 2022

Labels

Added: ?

d34ef4d 23 Feb 2022

Update tinymcebuilder.php

7356e7c 23 Feb 2022

Merge branch '4.1-dev' into 4.1-dev-tiny_lang

bembelimen - comment - 3 Mar 2022

@brianteeman and @infograf768 would you kindly please re-test?

bembelimen - change - 8 Mar 2022

Status

Ready to Commit

⇒

Pending

bembelimen - change - 8 Mar 2022

Status

Pending

⇒

Ready to Commit

bembelimen - change - 8 Mar 2022

Status

Ready to Commit

⇒

Pending

bembelimen - comment - 8 Mar 2022

Revert RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.}

a71ee37 8 Mar 2022

Merge branch '4.1-dev' into 4.1-dev-tiny_lang

bembelimen - change - 8 Mar 2022

Labels

Added: Release Blocker
Removed: ?

richard67 - comment - 12 Mar 2022

@brianteeman @infograf768 Could you test again? Thanks in advance.

brianteeman - comment - 13 Mar 2022

Tinymce not loaded n the builder

brianteeman - comment - 13 Mar 2022

I have tested this item ? unsuccessfully on a71ee37

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.}

brianteeman - test_item - 13 Mar 2022 - Tested unsuccessfully

b422504 13 Mar 2022

Update layouts/plugins/editors/tinymce/field/tinymcebuilder.php

brianteeman - comment - 13 Mar 2022

I have tested this item ✅ successfully on b422504

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.}

brianteeman - test_item - 13 Mar 2022 - Tested successfully

richard67 - comment - 13 Mar 2022

I have just tested with automatic language detection and with manual language. It works all fine in the editor (backend and frontend).

But in the plugin options the manual language seems not to work for me with this PR applied. The editor elements in the plugin's settings are shown in the current backend language when I have switched off the automatic language detection and chosen a different language as editor language some time before.

@brianteeman Can you confirm that?

richard67 - comment - 13 Mar 2022

P.S.: I mean the parts marked with red in this comment: #37061 (comment) . Without this PR they are in English, with this PR they are in current backend language regardless of the automatic language detection being switched on or off.

dgrammatiko - comment - 13 Mar 2022

Without this PR they are in English, with this PR they are in current backend language regardless of the automatic language detection being switched on or off.

I think this is the expected behaviour. The plugin adapts to the backend language for its own options. The language settings are affecting only the tinMCE (the editor either in the front end or back end).

EDIT unless if that wasn't the previous behaviour so then we have to match what was there

EDIT2: This is expected behaviour as the language for the builder defaults to the current backend language according to the code:

joomla-cms/plugins/editors/tinymce/src/Field/TinymcebuilderField.php

Lines 167 to 183 in cb07dbd

    
           // Check for TinyMCE language file 
        
           $language      = Factory::getLanguage(); 
        
           $languageFile1 = 'media/vendor/tinymce/langs/' . $language->getTag() . (JDEBUG ? '.js' : '.min.js'); 
        
           $languageFile2 = 'media/vendor/tinymce/langs/' . substr($language->getTag(), 0, strpos($language->getTag(), '-')) . (JDEBUG ? '.js' : '.min.js'); 
        
           $data['languageFile'] = ''; 
        
           if (file_exists(JPATH_ROOT . '/' . $languageFile1)) 
        
           { 
        
           	$data['languageFile'] = $languageFile1; 
        
           } 
        
           elseif (file_exists(JPATH_ROOT . '/' . $languageFile2)) 
        
           { 
        
           	$data['languageFile'] = $languageFile2; 
        
           } 
        
           $this->layoutData = $data;

brianteeman - comment - 13 Mar 2022

@richard67 that is the expected behaviour

richard67 - comment - 13 Mar 2022

I have tested this item ✅ successfully on b422504

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.}

richard67 - test_item - 13 Mar 2022 - Tested successfully

richard67 - change - 13 Mar 2022

Status

Pending

⇒

Ready to Commit

richard67 - comment - 13 Mar 2022

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37075.}

8942e88 18 Mar 2022

Dep

dgrammatiko - change - 18 Mar 2022

Labels

Added: ?

bembelimen - change - 18 Mar 2022

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2022-03-18 07:54:02
Closed_By		⇒	bembelimen

bembelimen - close - 18 Mar 2022

bembelimen - merge - 18 Mar 2022

bembelimen - comment - 18 Mar 2022

Thx

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#37075] - [4.1.1][regression] TinyMCE language misbehaving

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Add a Comment

	// Check for TinyMCE language file
	$language = Factory::getLanguage();
	$languageFile1 = 'media/vendor/tinymce/langs/' . $language->getTag() . (JDEBUG ? '.js' : '.min.js');
	$languageFile2 = 'media/vendor/tinymce/langs/' . substr($language->getTag(), 0, strpos($language->getTag(), '-')) . (JDEBUG ? '.js' : '.min.js');

	$data['languageFile'] = '';

	if (file_exists(JPATH_ROOT . '/' . $languageFile1))
	{
	$data['languageFile'] = $languageFile1;
	}
	elseif (file_exists(JPATH_ROOT . '/' . $languageFile2))
	{
	$data['languageFile'] = $languageFile2;
	}

	$this->layoutData = $data;