Set the button Last to Hide.
The path of the breadcrumps is correct.
The path of the breadcrumps does NOT display correctly, when the button Last is set to Hide.
J4.1
!
Button Last is set to Hide:
Button Last is set to Show (correct display):
Labels |
Removed:
?
|
Labels |
Added:
No Code Attached Yet
|
Labels |
Added:
bug
|
line 67 prints breadcrumbs in \modules\mod_breadcrumbs\tmpl\default.php. It should not be there (comment it or delete), but in 2 upper places
Whole foreach loop just above that line should look like this:
// Generate the trail
foreach ($list as $key => $item) :
if ($key !== $last_item_key) :
if (!empty($item->link)) :
$breadcrumbItem = HTMLHelper::_('link', Route::_($item->link), '<span>' . $item->name . '</span>', ['class' => 'pathway']);
else :
$breadcrumbItem = '<span>' . $item->name . '</span>';
endif;
echo '<li class="mod-breadcrumbs__item breadcrumb-item' . $class . '">' . $breadcrumbItem . '</li>';
elseif ($show_last) :
// Render last item if required.
$breadcrumbItem = '<span>' . $item->name . '</span>';
$class = ' active';
echo '<li class="mod-breadcrumbs__item breadcrumb-item' . $class . '">' . $breadcrumbItem . '</li>';
endif;
endforeach;
@pippo8765 please submit a pull request.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-18 15:19:40 |
Closed_By | ⇒ | chmst |
Status | Closed | ⇒ | New |
Closed_Date | 2022-02-18 15:19:40 | ⇒ | |
Closed_By | chmst | ⇒ |
Sorry @pippo8765 could you please make your PR against the dev 4.1-dev branch of the joomla-cms?
Maybe this will help you ?
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests/en
Yes, thank you, I tried posting request against J 4.1 branch, but seemed like I have no permissions to do that. Button is grayed. Also, didn't do much with git, so I'll go through your doc.
Thanks!
-- S poštovanjem,/Kind regards, Filip Jovic M.Sc. E. E. JUNIS, University of Niš +381 18 257 085, lok: 152 st: Univezitetski trg 2 ------------------------------------------- +381 64 61 54 557 @.***
On 18 Feb 2022 at 16:50, jsanders @.***> wrote:
Maybe this will help you ?
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests/en
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>
Also, didn't do much with git, so I'll go through your doc.
You don't need git.
Look up the file in the desired J4.1 branch
All you need to do is cut and paste.
@pippo8765 You can simply go to 4.1-dev...pippo8765:pippo8765-patch-1 fill out the PR template and submit it
Maybe this will help you ?
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests/en
Hi again, this above is exactly the process I used (seemed logical) and as stated in doc I ended up with new branch created, https://github.com/pippo8765/joomla-cms... Also I went through Pull Request form and filled it. So all went exactly as described in docs link. Now if someone is willing to instruct me what I did wrong :) I expected it to appear under https://github.com/joomla/joomla-cms/pulls but it did not happen :)
Thank you!
@pippo8765 Maybe you can do something with this?
Creating a pull request:
Closing as having a pull request.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-16 08:13:58 |
Closed_By | ⇒ | richard67 |
Thanks @pippo8765
PR #37282
I can confirm and on the homepage it is worse