No Code Attached Yet bug
avatar sandewt
sandewt
17 Feb 2022

Steps to reproduce the issue

Set the button Last to Hide.

Expected result

The path of the breadcrumps is correct.

Actual result

The path of the breadcrumps does NOT display correctly, when the button Last is set to Hide.

System information (as much as possible)

J4.1

Additional comments

screen shot 2022-02-17 at 07 01 17!
Button Last is set to Hide:
Schermafbeelding 2022-02-17 075404
Button Last is set to Show (correct display):
Schermafbeelding 2022-02-17 075218

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar sandewt sandewt - open - 17 Feb 2022
avatar sandewt sandewt - change - 17 Feb 2022
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Feb 2022
avatar sandewt sandewt - change - 17 Feb 2022
The description was changed
avatar sandewt sandewt - edited - 17 Feb 2022
avatar drmenzelit
drmenzelit - comment - 18 Feb 2022

I can confirm and on the homepage it is worse

grafik

avatar chmst chmst - change - 18 Feb 2022
Labels Added: bug
avatar chmst chmst - labeled - 18 Feb 2022
avatar pippo8765
pippo8765 - comment - 18 Feb 2022

line 67 prints breadcrumbs in \modules\mod_breadcrumbs\tmpl\default.php. It should not be there (comment it or delete), but in 2 upper places
Whole foreach loop just above that line should look like this:

// Generate the trail
foreach ($list as $key => $item) :
   if ($key !== $last_item_key) :
      if (!empty($item->link)) :
         $breadcrumbItem = HTMLHelper::_('link', Route::_($item->link), '<span>' . $item->name . '</span>', ['class' => 'pathway']);
      else :
         $breadcrumbItem = '<span>' . $item->name . '</span>';
      endif;
      echo '<li class="mod-breadcrumbs__item breadcrumb-item' . $class . '">' . $breadcrumbItem . '</li>';
      elseif ($show_last) :
      // Render last item if required.
         $breadcrumbItem = '<span>' . $item->name . '</span>';
         $class = ' active';
         echo '<li class="mod-breadcrumbs__item breadcrumb-item' . $class . '">' . $breadcrumbItem . '</li>';
      endif;
endforeach;

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37076.
avatar Quy
Quy - comment - 18 Feb 2022

@pippo8765 please submit a pull request.

avatar chmst chmst - change - 18 Feb 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-02-18 15:19:40
Closed_By chmst
avatar chmst chmst - close - 18 Feb 2022
avatar chmst
chmst - comment - 18 Feb 2022

Closing as there is a pull request. Please test #3707

avatar chmst chmst - change - 18 Feb 2022
Status Closed New
Closed_Date 2022-02-18 15:19:40
Closed_By chmst
avatar chmst chmst - reopen - 18 Feb 2022
avatar chmst
chmst - comment - 18 Feb 2022

Sorry @pippo8765 could you please make your PR against the dev 4.1-dev branch of the joomla-cms?

avatar pippo8765
pippo8765 - comment - 18 Feb 2022

Yes, thank you, I tried posting request against J 4.1 branch, but seemed like I have no permissions to do that. Button is grayed. Also, didn't do much with git, so I'll go through your doc.

Thanks!

-- S poštovanjem,/Kind regards, Filip Jovic M.Sc. E. E. JUNIS, University of Niš +381 18 257 085, lok: 152 st: Univezitetski trg 2 ------------------------------------------- +381 64 61 54 557 @.***

On 18 Feb 2022 at 16:50, jsanders @.***> wrote:

@pippo8765

Maybe this will help you ?

https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests/en


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>

avatar sandewt
sandewt - comment - 18 Feb 2022

Also, didn't do much with git, so I'll go through your doc.

You don't need git.

Look up the file in the desired J4.1 branch
All you need to do is cut and paste.

avatar wojsmol
wojsmol - comment - 18 Feb 2022

@pippo8765 You can simply go to 4.1-dev...pippo8765:pippo8765-patch-1 fill out the PR template and submit it 😄

avatar pippo8765
pippo8765 - comment - 18 Feb 2022

@pippo8765

Maybe this will help you ?

https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests/en

Hi again, this above is exactly the process I used (seemed logical) and as stated in doc I ended up with new branch created, https://github.com/pippo8765/joomla-cms... Also I went through Pull Request form and filled it. So all went exactly as described in docs link. Now if someone is willing to instruct me what I did wrong :) I expected it to appear under https://github.com/joomla/joomla-cms/pulls but it did not happen :)
Thank you!

avatar sandewt
sandewt - comment - 19 Feb 2022

@pippo8765 Maybe you can do something with this?

Creating a pull request:

  • Switch to the branch that you want to create a pull request for. ...
  • Click Create Pull Request. ...
  • On GitHub, confirm that the branch in the base: drop-down menu is the branch where you want to merge your changes. ...
  • Type a title and description for your pull request.

https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/working-with-your-remote-repository-on-github-or-github-enterprise/creating-an-issue-or-pull-request


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37076.
avatar richard67 richard67 - close - 16 Mar 2022
avatar richard67
richard67 - comment - 16 Mar 2022

Closing as having a pull request.

avatar richard67 richard67 - change - 16 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-16 08:13:58
Closed_By richard67
avatar sandewt
sandewt - comment - 16 Mar 2022

Thanks @pippo8765

PR #37282

Add a Comment

Login with GitHub to post a comment