[#36950] - [3.10] Improve core update quickicon as well as none-supported update messages
- Fixed in Code Base
- 11 Jun 2022
- Medium
- Build: 3.10-dev
- # 36950
- Diff
- zero-24:joomlaupdate_quickicon
User tests: Successful: Unsuccessful:
Pull Request for a first subset of the issues reported here #36610 .
Summary of Changes
- Make sure we use the current information we got from the detailsurl on the
getUpdateInformationmethod - Check whether we have got actually an update from the detailsurl or not.
- Improve joomla update quickicon to use
getUpdateInformationvs something from com_installer => This should improve the issues with that quickicon pointing to an outdated version too once merged up to J4 - Deprecate
$this->updateInformation['current']and move the core to use$this->updateInformation['installed']=> Only keep that old value so that possible admin template overrides are still working
Testing Instructions
First test
- Install 3.10.6-rc1 on php 5.6 (or on any other none supported setup for J4)
- switch to the testing update server
- apply this patch
- Check the Joomla update quickicon (=> The update should not be shown)
- go to Joomla Update (=> You only see reinstall)
seccond test
- Install 3.10.6-rc1 on a J4 supported setup
- switch to the testing update server
- apply this patch
- Check the Joomla update Quickicon (=> Update to J4 are shown)
- go to Joomla Update (=> Update to J4 are shown)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Templates (admin) JavaScript Front End Plugins |
| Labels |
Added:
?
|
||
it's almost same as expected, can you please review my screenshot so that I will consider as an successful testing, thanks in advance.
@pritam825 I'm sorry I did not saw your message earlier yes thats a good test you can try to hit "Check for Updates" to get the reinstall page again too.
| Labels |
Added:
PBF
|
||
I have tested this item
Thanks @zero-24
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36950.
| Category | Administration com_joomlaupdate Templates (admin) JavaScript Front End Plugins | ⇒ | Administration com_joomlaupdate Templates (admin) Libraries JavaScript Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36950.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-11 16:58:54 |
| Closed_By | ⇒ | zero-24 |
Thanks @tecpromotion and @SniperSister for finding the longstanding issue with the strtolower which caused this mess in the first place. Yes it was me who did the bad code :)
it's almost same as expected, can you please review my screenshot so that I will consider as an successful testing, thanks in advance.
