[#36951] - [3.10] Fix redirect updating new_url value
- Fixed in Code Base
- 20 Feb 2022
- Medium
- Build: 3.10-dev
- # 36951
- Diff
- zero-24:redirect
User tests: Successful: Unsuccessful:
Pull Request for Issue #36862 original work done by @tonypartridge here: #36873
Summary of Changes
Remove the direct changes to the redirect object and updating of new_url
Testing Instructions
Without this PR add a redirect and publish it into com_redirects, for example:
Source:
/my-custom-error
Destination
/my-real-live-page
access
/my-custom-error?query_junk_here
Actual result BEFORE applying this Pull Request
you are redirected to:
/my-real-live-page?query_junk_here
Try it again and you will see you are redirected to:
/my-real-live-page?query_junk_here?query_junk_here
Because before this PR the DB is updated.
Expected result AFTER applying this Pull Request
You are redirected to: /my-custom-error?query_junk_here
But your redirect in the database is not changed.
Documentation Changes Required
None. But it has to be merged up to J4 once tested against 3.10
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
Fails to redirect correctly.
Incorrect variable naming convention, starts as $newUrl and changed to $new_url. Please update all to be $newUrl as per camel caps naming convention.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36951.
| Labels |
Added:
?
|
||
Ouch .. fixed thanks @tonypartridge
I have tested this item
Welcomes! Perfect tested.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36951.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36951.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36951.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-20 09:26:50 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merging thanks
Sorry to ask but has this been released in 3.10.7 finally or not ?
Yes it has been released with 3.10.7
Ok, thanks.
Thanks @zero-24 - Will get this tested.