Language Change PBF ? Pending

User tests: Successful: Unsuccessful:

avatar ditsuke
ditsuke
3 Feb 2022

Addresses a concern from #36201.

Summary of Changes

  • Saving responses from the GET Request is now optional and disabled by default.
  • The saved result now uses the tmp_dir from the global configuration.

Testing Instructions

  • Make a task G1 with the GET Request routine, keep "Save Response" disabled.
  • Make another task G2 with "Save Response" enabled.
  • Trigger the tasks either by waiting or by manually running from the list view.

Actual result BEFORE applying this Pull Request

  • There is no option to not save the response.
  • Response is saved in the tmp/ directory blind to the tmp_dir configuration.

Expected result AFTER applying this Pull Request

  • There is an option to not save the response making retention opt-in. Response for the G1 task is not saved while response for the G2 task is saved.
  • tmp_dir configuration is respected.

Documentation Changes Required

nil

avatar ditsuke ditsuke - open - 3 Feb 2022
avatar ditsuke ditsuke - change - 3 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2022
Category Administration Language & Strings Front End Plugins
avatar ditsuke ditsuke - change - 3 Feb 2022
Labels Added: Language Change ?
avatar ditsuke ditsuke - change - 3 Feb 2022
Title
Make it Optional to Save Response from the GET Request Task Routine
[4.1] Make it Optional to Save Response from the GET Request Task Routine
avatar ditsuke ditsuke - edited - 3 Feb 2022
avatar ditsuke ditsuke - change - 22 Apr 2022
Labels Added: PBF
avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar MacJoom
MacJoom - comment - 26 Aug 2023

Needs to updated, Call to undefined method Joomla\Component\Scheduler\Administrator\Table\TaskTable::getCurrentUser()

avatar HLeithner
HLeithner - comment - 26 Aug 2023

Needs to updated, Call to undefined method Joomla\Component\Scheduler\Administrator\Table\TaskTable::getCurrentUser()

is fixed in 5.0 already, but this pr conflicts and has to be resolved

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

Add a Comment

Login with GitHub to post a comment