User tests: Successful: Unsuccessful:
Pull Request for Issue #35587 (partly)
Related to #21330
Make sure automatic title is enabled by default like we had it in 2.5
Install package build for this PR by dron and confirm that the setting Automatic Title
is enabled for Popular Articles
, Recently Added Articles
, Logged-in Users
and Latest Actions
.
The setting is disabled and just the original title is displayed.
The setting is enabled and shows the generated title instead of the default.
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration SQL Installation Postgresql |
Title |
|
Labels |
Added:
?
|
@richard67 Issue number updated.
@richard67 This PR fixes #35587 only partially for modules witch have automatic title support.
@richard67 This PR fixes #35587 only partially for modules witch have automatic title support.
@wojsmol Then you should have written something like „Pull request for issue #35587 (partly)“ at the top of your PR. It causes us additional work to sort out which issues to close or not to close it people don’t properly refer to issues in their PRs.
@richard67 PR description fixed
Thanks.
Yes thats why we first asked the 4.2 release leads and they signaled us that such a PR would be accepted into 4.2 to improve non-english backends. This PR is only changing it for new installations so existing installations are still working as they do now. :)
And someone was to know that how? Mind-reading?
This PR is incomplete. There is zero point in just having a few modules in the admin language. If you're going to do this then do it properly and make sure that all the modules etc have automatic titles.
Also please move the switch to use the automatic titles to the main tab. Otherwise we will have users (once again) who dont understand why none of the changes they make to the module titles work.
I have tested this item
This breaks(?) all existing sites.
On an existing site the installation sql did not add the default value of automatic_title=0 which was not really a problem as it matched the default settings in the module xml
However this PR changes all of that.
On an existing site - apply this PR.
There is no visible change and modules still use the natural title
Open any article for editing and you will be confused as it will show that automatic titles are being used - they're not
Open any article for editing and change the title and save - now you will be confused as your module is neither using the original title or the title you just set. Instead it will use the automatic title.
@brianteeman Issue reported in #36954 (comment) was fixed in 799a64a
The pr is still incomplete as shown in the screenshots
Restart of drone test is required.
Category | Modules Administration SQL Installation Postgresql | ⇒ | Administration Language & Strings Modules SQL Installation Postgresql |
Labels |
Added:
Language Change
|
Can someone restart drone please
@brianteeman I just merged latests 4.2-devf into branch of this PR but tests are still failing.
yes looks like the new sampledata helper is not loaded in the module yet. i was sure i have tested that too but looks like i have not.
yes looks like the new sampledata helper is not loaded in the module yet. i was sure i have tested that too but looks like i have not.
The log shows that installation works well, but then it fails to unpublish the statistics module. Possibly the tests need to be adjusted to a changed module title or something like that? If that is the case, all human tests will work and only the automated tests fail as long as not adapted.
This PR is still incomplete
@brianteeman Can you elaborate what is missing?
the main problem however with this PR is it is completely non intuitive.
The principle of the pr is a good one but the implementation is wrong. If you look elsehwere in Joomla 4 where we have translatable titles it is much clearer.
As it is right now there is no way that a new user would understand that the title the title of the module Latest Articles can not be changed unless they also turn off the automatic title setting. It just looks like a bad bug that the title never changes no matter what you put in the module.
Take a look at workflows for an example of how it could be done
This pull requests has been automatically converted to the PSR-12 coding standard.
Labels |
Added:
?
?
|
This pull request has been automatically rebased to 5.0-dev.
This pull request has been automatically rebased to 5.1-dev.
This pull request has been automatically rebased to 5.2-dev.
Title |
|
I have tested this item ? unsuccessfully on 0112e2a
@richard67 I quite agree that it does not make much sense to test PRs that have conflicts. But I strongly plead for an important enhancement for the Joomla! Patch Tester. There should be a filter in order to hide such PRs. For non-professional test persons it is anyway alread challenging (instructions are in a foreign language, not always very clear). Additionally having to check Github and reading the whole conversation from top to bottom before starting tests is tedious and lowers the willingness to contribute.
This pull request has been automatically rebased to 5.3-dev.
Title |
|
@wojsmol Could you refer to the right issue #35587 instead of the duplicate #35820 ? Thanks in advance.