Language Change ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
6 Feb 2022

Pull Request for Issue #35587 (partly)
Related to #21330

Summary of Changes

Make sure automatic title is enabled by default like we had it in 2.5

Testing Instructions

Install package build for this PR by dron and confirm that the setting Automatic Title is enabled for Popular Articles, Recently Added Articles, Logged-in Users and Latest Actions.

Actual result BEFORE applying this Pull Request

The setting is disabled and just the original title is displayed.

Expected result AFTER applying this Pull Request

The setting is enabled and shows the generated title instead of the default.

Documentation Changes Required

avatar wojsmol wojsmol - open - 6 Feb 2022
avatar wojsmol wojsmol - change - 6 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2022
Category Modules Administration SQL Installation Postgresql
avatar wojsmol wojsmol - change - 6 Feb 2022
Title
Enable automatic title for admin modules
[4.2] Enable automatic title for admin modules
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar wojsmol wojsmol - change - 6 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar wojsmol wojsmol - change - 6 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar wojsmol wojsmol - change - 6 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar wojsmol wojsmol - change - 6 Feb 2022
Labels Added: ?
avatar richard67
richard67 - comment - 6 Feb 2022

@wojsmol Could you refer to the right issue #35587 instead of the duplicate #35820 ? Thanks in advance.

avatar wojsmol wojsmol - change - 6 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar wojsmol wojsmol - change - 6 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar wojsmol
wojsmol - comment - 6 Feb 2022

@richard67 Issue number updated.

avatar wojsmol wojsmol - change - 6 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar wojsmol
wojsmol - comment - 6 Feb 2022

@richard67 This PR fixes #35587 only partially for modules witch have automatic title support.

avatar richard67
richard67 - comment - 6 Feb 2022

@richard67 This PR fixes #35587 only partially for modules witch have automatic title support.

@wojsmol Then you should have written something like „Pull request for issue #35587 (partly)“ at the top of your PR. It causes us additional work to sort out which issues to close or not to close it people don’t properly refer to issues in their PRs.

avatar wojsmol wojsmol - change - 6 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar wojsmol
wojsmol - comment - 6 Feb 2022

@richard67 PR description fixed

avatar richard67
richard67 - comment - 6 Feb 2022

Thanks.

avatar brianteeman
brianteeman - comment - 6 Feb 2022
avatar zero-24
zero-24 - comment - 6 Feb 2022

#21330

Yes thats why we first asked the 4.2 release leads and they signaled us that such a PR would be accepted into 4.2 to improve non-english backends. This PR is only changing it for new installations so existing installations are still working as they do now. :)

avatar brianteeman
brianteeman - comment - 6 Feb 2022

#21330

Yes thats why we first asked the 4.2 release leads and they signaled us that such a PR would be accepted into 4.2 to improve non-english backends. This PR is only changing it for new installations so existing installations are still working as they do now. :)

And someone was to know that how? Mind-reading?

avatar brianteeman
brianteeman - comment - 6 Feb 2022

This PR is incomplete. There is zero point in just having a few modules in the admin language. If you're going to do this then do it properly and make sure that all the modules etc have automatic titles.

avatar brianteeman
brianteeman - comment - 6 Feb 2022

image

image

avatar brianteeman
brianteeman - comment - 6 Feb 2022

Also please move the switch to use the automatic titles to the main tab. Otherwise we will have users (once again) who dont understand why none of the changes they make to the module titles work.

avatar wojsmol wojsmol - change - 6 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 6 Feb 2022
avatar brianteeman brianteeman - test_item - 7 Feb 2022 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 7 Feb 2022

I have tested this item 🔴 unsuccessfully on 4666c95

This breaks(?) all existing sites.

On an existing site the installation sql did not add the default value of automatic_title=0 which was not really a problem as it matched the default settings in the module xml

However this PR changes all of that.

On an existing site - apply this PR.
There is no visible change and modules still use the natural title
Open any article for editing and you will be confused as it will show that automatic titles are being used - they're not
Open any article for editing and change the title and save - now you will be confused as your module is neither using the original title or the title you just set. Instead it will use the automatic title.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36954.
avatar wojsmol
wojsmol - comment - 7 Feb 2022

@brianteeman Issue reported in #36954 (comment) was fixed in 799a64a

avatar brianteeman
brianteeman - comment - 7 Feb 2022

The pr is still incomplete as shown in the screenshots

avatar wojsmol wojsmol - change - 7 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 7 Feb 2022
avatar wojsmol
wojsmol - comment - 18 Feb 2022

Restart of drone test is required.

avatar brianteeman
brianteeman - comment - 18 Feb 2022

Drone issue is my fault. Will need #37092 to be merged to resolve that

avatar wojsmol wojsmol - change - 23 Feb 2022
The description was changed
avatar wojsmol wojsmol - edited - 23 Feb 2022
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2022
Category Modules Administration SQL Installation Postgresql Administration Language & Strings Modules SQL Installation Postgresql
avatar wojsmol wojsmol - change - 4 May 2022
Labels Added: Language Change
avatar wojsmol wojsmol - change - 4 May 2022
The description was changed
avatar wojsmol wojsmol - edited - 4 May 2022
avatar brianteeman
brianteeman - comment - 25 May 2022

Can someone restart drone please

avatar wojsmol wojsmol - change - 25 May 2022
The description was changed
avatar wojsmol wojsmol - edited - 25 May 2022
avatar wojsmol
wojsmol - comment - 25 May 2022

@brianteeman I just merged latests 4.2-devf into branch of this PR but tests are still failing.

avatar zero-24
zero-24 - comment - 26 May 2022

yes looks like the new sampledata helper is not loaded in the module yet. i was sure i have tested that too but looks like i have not.

avatar richard67
richard67 - comment - 26 May 2022

yes looks like the new sampledata helper is not loaded in the module yet. i was sure i have tested that too but looks like i have not.

The log shows that installation works well, but then it fails to unpublish the statistics module. Possibly the tests need to be adjusted to a changed module title or something like that? If that is the case, all human tests will work and only the automated tests fail as long as not adapted.

avatar brianteeman
brianteeman - comment - 9 Jun 2022

This PR is still incomplete

avatar wojsmol wojsmol - change - 9 Jun 2022
The description was changed
avatar wojsmol wojsmol - edited - 9 Jun 2022
avatar wojsmol
wojsmol - comment - 9 Jun 2022

@brianteeman Can you elaborate what is missing?

avatar brianteeman
brianteeman - comment - 9 Jun 2022

same as I reported before

image

avatar brianteeman
brianteeman - comment - 9 Jun 2022

the main problem however with this PR is it is completely non intuitive.

The principle of the pr is a good one but the implementation is wrong. If you look elsehwere in Joomla 4 where we have translatable titles it is much clearer.

As it is right now there is no way that a new user would understand that the title the title of the module Latest Articles can not be changed unless they also turn off the automatic title setting. It just looks like a bad bug that the title never changes no matter what you put in the module.

Take a look at workflows for an example of how it could be done
image

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar wojsmol wojsmol - change - 21 Oct 2022
Labels Added: ? ?
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[4.2] Enable automatic title for admin modules
[5.2] Enable automatic title for admin modules
avatar HLeithner HLeithner - edited - 24 Apr 2024

Add a Comment

Login with GitHub to post a comment