[#36867] - [5.0] Smart Search: Allow to select which taxonomies to index
- Fixed in Code Base
- 29 May 2023
- Medium
- Build: 4.2-dev
- # 36867
- Diff
- Hackwar:4.2-finder-plgoptions
User tests: Successful: Unsuccessful:
Pull Request for Issue #26233.
Summary of Changes
This allows you to set which taxonomies should be indexed by a finder plugin.
Testing Instructions
- Setup a site with some content.
- Disable all finder plugins except for one (to test them one by one)
- Edit the last active finder plugin and select which taxonomies to index from the list of checkboxes.
- Run the indexer
Actual result BEFORE applying this Pull Request
All taxonomies were indexed each time.
Expected result AFTER applying this Pull Request
Only the selected taxonomies are indexed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Language & Strings Front End Plugins |
| Labels |
Added:
Language Change
?
|
||
The index behavior when the category which the item belong to is missing is inconsistent in finder plugins. In contact plugin, we stop indexing item if category not found, while in content plugin, the index process is continued
I think if category not found, we should not index the item, not depend on Category is selected to index or not. I tried to delete a category from database, the article still being indexed and searchable. However, the link to that article throws 404 error, so I don't think it is right.
Could you please check it?
| Labels |
Added:
?
|
||
@Hackwar Could you check the comment above #36867 (comment) ?
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
I looked into this and my first reaction was to refuse a change, but @joomdonation is right here. We should not index an item if it doesn't have a category or a category can't be loaded. I changed the code accordingly. I would be really gratefull for tests to maybe still get this into 4.2?
| Title |
|
||||||
| Labels |
Added:
PR-4.3-dev
Removed: ? |
||
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Added:
Conflicting Files
|
||
| Labels |
Removed:
Conflicting Files
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
Documentation Required
PR-5.0-dev
PR-4.4-dev
Removed: PR-4.3-dev |
||
How would this look like for custom fields (in the future)? Would we add this option as custom field attribute?
| Labels |
Added:
?
Removed: PR-4.4-dev |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-18 12:06:26 |
| Closed_By | ⇒ | Hackwar |
Why closed? Should we reopen the original issue?
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-04-18 12:06:26 | ⇒ | |
| Closed_By | Hackwar | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-29 08:17:55 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
Feature
Removed: ? |
||
thanks
We need documentation for this
I have tested this item✅ successfully on beff9ea
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.