[#36868] - Fixed Scheduler: "task failed" counts twice
- Fixed in Code Base
- 31 Jan 2022
- Medium
- Build: 4.1-dev
- # 36868
- Diff
- Shubhamverma2796:issue_36859
User tests: Successful: Unsuccessful:
Pull Request for Issue #36859 .
Summary of Changes
Removed +1 from the 'time_failed' query
Testing Instructions
- Go to Scheduled Tasks and add a GET Request
- Enter an invalid URL to Request URL (e.g. http://jooomla.org)
- Execution Rule: manual
- Save the task
- Run the task once
Actual result BEFORE applying this Pull Request
The count of 'Times failed' is incorrect. It should be equal to the Times Executed.
Expected result AFTER applying this Pull Request
The count of 'Times failed' increments by +1 only if the task fails.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36868.
| Labels |
Added:
?
?
|
||
@chmst @pritam825 Could you tested again with the latest changeable this PR? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36868.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36868.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36868.
| Labels |
Added:
?
Removed: ? |
||
@Shubhamverma2796 There is no need to update your branch as long as there are no conflicts shown. Updating the branch invalidates the human tests counter so I have to add back the tests.
Added back the human tests.
@Shubhamverma2796 There is no need to update your branch as long as there are no conflicts shown. Updating the branch invalidates the human tests counter so I have to add back the tests.
Sorry I was not aware of this fact.
I have tested this item
working as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36868.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-31 15:25:11 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item✅ successfully on 78037c2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36868.